[debhelper-devel] [debhelper] 02/02: Add a few TODOs

[Michael Biebl]

This is an automated email from the git hooks/post-receive script.

biebl pushed a commit to branch biebl/meson
in repository debhelper.

commit 62422d365179100a708099f4b859484a4ac6722d
Author: Michael Biebl <biebl at debian.org>
Date:   Fri Mar 24 16:57:58 2017 +0100

    Add a few TODOs
---
 Debian/Debhelper/Buildsystem/meson.pm |  3 +++
 Debian/Debhelper/Buildsystem/ninja.pm | 10 ++++++++++
 2 files changed, 13 insertions(+)

diff --git a/Debian/Debhelper/Buildsystem/meson.pm b/Debian/Debhelper/Buildsystem/meson.pm
index 286fe1c..551b4f7 100644
--- a/Debian/Debhelper/Buildsystem/meson.pm
+++ b/Debian/Debhelper/Buildsystem/meson.pm
@@ -35,6 +35,9 @@ sub new {
 sub configure {
 	my $this=shift;
 
+	# TODO: Support cross compilation
+	# https://github.com/mesonbuild/meson/wiki/Cross-compilation
+
 	# Standard set of options for meson.
 	my @opts;
 	push @opts, "--buildtype=plain";
diff --git a/Debian/Debhelper/Buildsystem/ninja.pm b/Debian/Debhelper/Buildsystem/ninja.pm
index d1ceeb0..3acfb84 100644
--- a/Debian/Debhelper/Buildsystem/ninja.pm
+++ b/Debian/Debhelper/Buildsystem/ninja.pm
@@ -45,6 +45,14 @@ sub check_auto_buildable {
 sub build {
 	my $this=shift;
 	unshift @_,
+
+	# TODO: Add support for DEB_BUILD_OPTIONS="parallel=N"?
+	# By default ninja runs N jobs in parallel, where N is derived
+	# from the number of CPUs.
+	# Should this be only done for the build step or install and test as well?
+	# In the latter case, the code to run buildcmd should be factored out.
+
+	# TODO: Add support for DH_QUIET, i.e. don't run with -v in quiet mode.
 	$this->doit_in_builddir($this->{buildcmd}, "-v", @_);
 }
 
@@ -57,6 +65,8 @@ sub install {
 	my $this=shift;
 	my $destdir=shift;
 
+	# TODO: DESTDIR can only be set as environment variable. Save and restore
+	# $ENV after calling the install target?
 	$ENV{DESTDIR}=$destdir;
 	$this->doit_in_builddir($this->{buildcmd}, "install", @_);
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debhelper/debhelper.git