[debhelper-devel] Bug#415396: Bug#415396: "dh_install --list-missing" should ignore manpages and other installed files

[Michael Stapelberg]

On Sun, Mar 26, 2017 at 2:54 PM, Niels Thykier <niels at thykier.net> wrote:

> Michael Stapelberg:
> > Thanks for the additional details.
> >
> > Find attached a patch which splits the functionality into the new
> > dh_missing helper.
> >
>
> Thanks, :)
>
> > Aside from the fact that documentation is still missing, what are your
> > thoughts on that patch? Once documentation is added, could we merge it,
> > then change dh_installman and dh_installdocs?
> >
> > Thanks!
> >
> > [...]
>
> Remarks:
>
>  * For backwards compatibility, dh_install still has to do what it is
>    currently doing in compat 10 (or earlier).  Possibly by calling
>    dh_missing; possibly by keeping the existing code for now and only
>    using it in compat 10 or earlier.  Whichever works.
>    - reason: Otherwise we break people's expectations when they have
>      called dh_install --(list|fail)-missing.
>

Done.


>
>  * log_installed_files - what is the rationale behind doing a file
>    per helper?  It is fine if there is one, but if not, I would prefer
>    to keep things simple and just have one file.
>    - bonus side effect: Multiple calls inside the same helper would
>      become additive, which is probably better suited for how most
>      helpers work right now.
>

The rationale was to make debugging easier, and encourage future
parallelization of individual helpers (not sure if that’s planned at all).
I don’t have strong feelings about this, so let me know if it should be
changed (or go ahead and change it).


>
>  * Open question: Should we run dh_missing by default in "complain"
>    mode and then migrate to "fail mode" by default in a later compat
>    level
>

I think running it in complain mode once the remaining helpers were updated
makes sense. Before that, the false positives might annoy people more than
doing any good.

Migrating to fail mode is a separate beast altogether. We should gather
some data on how many packages would need to be updated due to such a
change before seriously considering it, I think.


>
> Beyond that, I am happy to merge it as a WIP thing.
>

Great. Find attached an updated patch including documentation.

Is there any large-scale testing that debhelper has, to confirm that my
change doesn’t break things so far?

-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20170326/38ce689c/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Move-dh_install-s-list-fail-missing-to-dh_missing.patch
Type: text/x-patch
Size: 12082 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20170326/38ce689c/attachment-0003.bin>