[debhelper-devel] lvm2: dh_installsystemd fragment generates warning during configuration

[Michael Biebl]

Control: reassign -1 debhelper 10.9.2

On Thu, 09 Nov 2017 21:59:27 +0000 Julian Gilbey <jdg at debian.org> wrote:
> Package: lvm2
> Version: 2.02.176-1
> Severity: normal
> 
> I don't know whether the bug here lies in dh_installsystemd or in
> lvm2, so please reassign to dh_installsystemd if this is the wrong
> package.
> 
> At the end of lvm2's debian/rules, it says:
> 	dh_installsystemd --remaining-packages
> 
> But the lvm2 postinst then ends up finishing with the following:
> 
> # Automatically added by dh_installsystemd/10.10.5
> if [ -d /run/systemd/system ]; then
> 	systemctl --system daemon-reload >/dev/null || true
> 	if [ -n "$2" ]; then
> 		_dh_action=try-restart
> 	else
> 		_dh_action=start
> 	fi
> 	deb-systemd-invoke $_dh_action  >/dev/null || true
> fi
> # End automatically added section
> 
> and this throws up the warning message:
> 
> Syntax: /usr/bin/deb-systemd-invoke <action> <unit file> [<unit file> ...]
> 
> because no unit file is listed after $_dh_action.
> 
> I'm inclined to think that this is a debhelper bug...
> 

I agree. Re-assigning to debhelper. dh_installsystemd should not
generate such a (bogus) start/restart action.

I wonder if this is a regression from dh_systemd_* or if the old tools
are affected as well.

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20171110/7929a72a/attachment-0003.sig>