[debhelper-devel] Bug#894549: debhelper: dh_usrlocal may remove a direct subdirectory of /usr/local

[Niels Thykier]

On Mon, 2 Apr 2018 16:53:52 +0200 Nicolas Boulenguez
<nicolas at debian.org> wrote:
> Package: debhelper
> Followup-For: Bug #894549
> 
> Hello.
> 
> This new diff should fix the same issues in dh_usrlocal.
> The result is more readable in my opinion, hopefully preventing
> similar errors in the future.
> 
> It should also be a bit more efficient: instead of sorting two huge
> lists of paths all starting with "/usr/share/", it sorts once simple
> names in each directory.
> 
> When a normal file is encountered, it displays an error instead of a
> warning. This does not change much, as rmdir would fail with a less
> explicit message when attempting to remove the containing directory.

Hi Nicolas,

Thanks for your finding and the patch.

While we are at the subject of making it more readable, perhaps I could
ask you convert dh_usrlocal to use the "hashref" based autoscript?  That
should avoid the need for the "\\\\\\\\\\\\\\\"-mess we currently have.

Also, many thanks for the other bugs you have filed recently.  I am very
grateful that you have included patches in them. :)

Thanks,
~Niels