[debhelper-devel] Bug#887727: Bug#887727: debhelper, dh-dist-zilla: dh-dist-zilla based package builds no more run dh_auto_install (and maybe other dh_auto_*)

[Niels Thykier]

Control: tags -1 patch moreinfo

Axel Beckert:
> Package: debhelper,dh-dist-zilla
> Version: debhelper/10.10.6
> Severity: serious
> Tags: sid buster
> Control: affects -1 src:roary src:systray-mdstat
> 
> Hi,
> 
> Sascha Steinbiss <satta at debian.org> (X-Debbugs-Cc'ed) made me aware
> that at least two dh-dist-zilla based source packages (roary and
> systray-mdstat) produce more or less empty packages when build now
> (but don't FTBFS and in case of systray-mdstat not even throw a single
> lintian warning).
> 
> An DH_VERBOSE=1 build log reveals that dh_auto_install is no more
> called in the build. (This probably also counts for other dh_auto_*
> scripts.) This smells a lot like being caused by this change in
> debhelper/10.10.6 (uploaded November 2017, i.e. shortly after the
> latest uploads of the two mentioned packages):
> 
>   * dh,dh_auto_*: Support skipping all of the dh_auto_* helpers if the
>     package does not seem to have a build system (and there are no
>     build system related options passed to dh).
> 
> Which is this commit:
> https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=52bf7ef7
> 
> Reverting this commit fixes the issue as dh_auto_install is called
> again.
> 
> So I now wonder:
> 
> * Is this a bug in debhelper? I.e. does the new (additional?)
>   buildsystem detection not work properly?
> 
> * Or is this a bug in dh-dist-zilla and it should have declared
>   something in
>   /usr/share/perl5/Debian/Debhelper/Sequence/dist_zilla.pm
>   which wasn't relevant yet, but is now?
> 
> 		Regards, Axel
> 

Hi Axel and Sascha,

Thanks for reporting the bug.

Could you please verify that the attached patch fixes the problem for you?

Thanks,
~Niels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dh-Always-run-commands-with-sequence-defined-options.patch
Type: text/x-patch
Size: 718 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20180120/2a32b412/attachment-0003.bin>