[debhelper-devel] Bug#887900: dh_installsystemd does not properly handle aliased services

[Michael Biebl]

Am 24.01.2018 um 21:32 schrieb Niels Thykier:
> On Sun, 21 Jan 2018 15:44:05 +0100 Michael Biebl <biebl at debian.org> wrote:
>> Package: debhelper
>> Version: 11.1.3
>> Severity: normal
>>
>> I use the following in network-manager:
>>
>> override_dh_systemd_start:
>>        dh_link -pnetwork-manager \
>>               lib/systemd/system/NetworkManager.service \
>>               lib/systemd/system/network-manager.service
>>        dh_systemd_start -pnetwork-manager --no-also NetworkManager.service
>>
>> The background is, that traditionally, the Debian SysV init script is
>> called /etc/init.d/network-manager and the upstream systemd service is
>> named NetworkManager.service
>>
>> I thus created the symlink which told dh_systemd_start to not generate
>> start code for NetworkManager.service (using deb-systemd-invoke) but
>> leave this up to invoke-rc.d network-manager
>>
>> It seems this no longer works with dh_installsystemd.
>>
>> [...]
> Hi Felipe,
> 
> What is your take on this bug?

I assume the answer will be basically the same as for
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887904#10

I think we should invert the logic and stop letting
dh_installinit/invoke-rc.d handle services which have a native systemd
.service file.
Maybe this could be as simple as letting dh_installinit in compat 11
generate code which wraps the invoke-rc.d call like this:

> if ! [ -d /run/systemd/system ] || ! [ -e /lib/sytemd/system/foo.service ] ; then
> 	invoke-rc.d foo $_dh_action || exit 1
> fi




-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20180124/2ec356f0/attachment-0001.sig>