[debhelper-devel] Bug#751207: debhelper: make it easy to pass --disable-silent-rules to configure

[Helmut Grohne]

Package: debhelper
Version: 9.20140228
Severity: normal
Tags: patch

Hi Joey,

I would like to see a simple way to make build logs verbose. In
particular this means passing --disable-silent-rules to configure. Now
this bug report looks like a duplicate of #680686 and #551463, but I
believe it is not.

In message https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680686#29
you wrote:
> I'd be ok with DH_VERBOSE enabling the verbose behavior, and the buildds
> could then enable it.

But the bug reports above specifically want to change the default. So in
this bug report I am not asking for changing the default, but merely
asking for an easy way to change the default (preferably by setting an
environment variable). So I implemented your proposal to pass
--disable-silent-rules when DH_VERBOSE is non-empty. (I actually wonder
why nobody did that so far.) Applying this patch would solve problems
for me today, because I cross-build packages with DH_VERBOSE being set
and am often stuck looking at silent build logs.

Thanks for considering

Helmut
-------------- next part --------------
diff -Nru debhelper-9.20140228/Debian/Debhelper/Buildsystem/autoconf.pm debhelper-9.20140228+nmu1/Debian/Debhelper/Buildsystem/autoconf.pm
--- debhelper-9.20140228/Debian/Debhelper/Buildsystem/autoconf.pm	2013-09-03 20:44:37.000000000 +0200
+++ debhelper-9.20140228+nmu1/Debian/Debhelper/Buildsystem/autoconf.pm	2014-06-10 21:14:18.000000000 +0200
@@ -37,6 +37,9 @@
 	push @opts, "--infodir=\${prefix}/share/info";
 	push @opts, "--sysconfdir=/etc";
 	push @opts, "--localstatedir=/var";
+	if (defined $ENV{DH_VERBOSE} && $ENV{DH_VERBOSE} ne "") {
+		push @opts, "--disable-silent-rules";
+	}
 	my $multiarch=dpkg_architecture_value("DEB_HOST_MULTIARCH");
 	if (! compat(8)) {
 	       if (defined $multiarch) {
diff -Nru debhelper-9.20140228/debian/changelog debhelper-9.20140228+nmu1/debian/changelog
--- debhelper-9.20140228/debian/changelog	2014-02-28 20:02:37.000000000 +0100
+++ debhelper-9.20140228+nmu1/debian/changelog	2014-06-10 22:17:27.000000000 +0200
@@ -1,3 +1,11 @@
+debhelper (9.20140228+nmu1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Pass --disable-silent-rules in dh_auto_configure if DH_VERBOSE is set.
+    Closes: #-1.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Tue, 10 Jun 2014 21:20:10 +0200
+
 debhelper (9.20140228) unstable; urgency=medium
 
   * Fix breakage in no-act mode introduced in last release.