[debhelper-devel] Bug#759812: Bug#759812: Make the multiarch tuple available in helpers

Joey Hess joeyh at debian.org
Sat Aug 30 17:57:40 UTC 2014


Christian Kastner wrote:
> The attached patch extends dh_installdirs, dh_install, and dh_link such
> that in v10 mode, the literal string :multiarch: is substituted with the
> appropriate multiarch tuple during their operation.

I think that Ubuntu had a patch for this or something similar 
earlier, so it may be good to reuse the syntax. Or perhaps ${multiarch}.

We need to avoid something that conflicts with anything in any debhelper
config files. It would be good to eg, grep the lintian lab.

> The substitution is currently applied not only to debian/package.*
> files, but to direct invocations of the dh_* helpers as well. I don't
> know if this is a problem.

It makes it harder to prove that it doesn't break anything currently.
Is there any use case for it?

> +my $multiarch=dpkg_architecture_value("DEB_HOST_MULTIARCH");

> +			s/:multiarch:/$multiarch/g for @$set;

This forces a call to dpkg-architecture in the common case where the
substitution is not used. Instead, it should only look up the value
once it find a use of it.

That will be more complicated, but this repeated code needs to be
refactored anyway..

-- 
see shy jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20140830/0ecc47f5/attachment-0001.sig>


More information about the debhelper-devel mailing list