[debhelper-devel] Bug#747141: Bug#747141: debhelper: "dh_installdocs --link-doc" breaks binNMUs

[Niels Thykier]

Hi Bernhard,

Thanks for looking into this. :)


On 2014-11-09 00:22, Bernhard R. Link wrote:
> 
> I guess the easiest thing to do is simply to warn and in future compat
> levels to error out with something like:
> 
> [...]
> 
> 
> [...]
> - aborting with an error in case there is a broken --link-doc and there
>   is an binNMU currently happening has the problem of detecting that the
>   dependency is actually affected (due to binary packages maybe having
>   differing versions) and could perhaps break some binNMU that by some
>   other hard to forsee factors perhaps would not create a broken
>   package.
> 
> Of those at most erroring out in case of binNMU that is considered to
> create uninstallable packages seems worth considering to me, and making
> that good enough to not create new problems looks hard.
> 
> 
> 	Bernhard R. Link
> 

I think the patch is definitely a good start.  However, I do think that
detecting and error'ing out on the "broken binNMU" case should be
trivially enough and much better than "silently"[1] continuing with the
build.
  I will look into extending your patch to handle that case as well.

~Niels

[1] There will be the warning, but no one reads the logs from the
buildds before it is too late.