[debhelper-devel] Bug#747141: Bug#747141: Bug#747141: Bug#747141: debhelper: "dh_installdocs --link-doc" breaks binNMUs

[Niels Thykier]

Control: tags -1 patch

On 2014-11-16 20:02, Niels Thykier wrote:
> On 2014-11-16 17:39, Niels Thykier wrote:
>> Hi Bernhard,
>>
>> Thanks for looking into this. :)
>>
>> [...]
>>
>> I think the patch is definitely a good start.  However, I do think that
>> detecting and error'ing out on the "broken binNMU" case should be
>> trivially enough and much better than "silently"[1] continuing with the
>> build.
>>   I will look into extending your patch to handle that case as well.
>>
>> ~Niels
>>
>> [1] There will be the warning, but no one reads the logs from the
>> buildds before it is too late.
>>
>> [...]
> 
> I got an extended patch (see attached diff file) that errors out on
> *some* binNMUs.  Turns out that there is a case it does not handle and
> that will be difficult to deal with.
> 
> The problem is when an arch:all package links to an arch:any package.
> In binNMU build, dh_installdocs will not see the "arch:all" package as
> it is told not to act on it.  This means that:
> 
> [...]

Ok, I got a solution for this as well.  I have attached 3 patches to
solve the issue.  The first one is pretty much the same as the previous
one.  The second one is to avoid a test failure because my 3rd patch
pushes the size of dh_installdocs beyond the limit of 200 (non-comment)
lines.
  The third patch makes dh_installdocs able to detect the "arch:all
--link-doc arch:any" case by keeping track of which packages have been
filtered out by an (implicit) -a option from DH_INTERNAL_OPTIONS).

~Niels


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dh_installdocs-Error-out-on-some-unsafe-binNMUs-with.patch
Type: text/x-patch
Size: 1998 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20141116/8653ee88/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-t-size-Ignore-empty-lines-when-counting-size-of-a-to.patch
Type: text/x-patch
Size: 708 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20141116/8653ee88/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dh_installdocs-Error-out-on-unsafe-binNMUs-with-link.patch
Type: text/x-patch
Size: 3555 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20141116/8653ee88/attachment-0008.bin>