[Debian-arabic-packages] Jcal review

Lior Kaplan kaplan at debian.org
Fri Apr 6 23:57:29 UTC 2007

Hi Alan,

Here are my comments regarding jcal:

1. Please host your sources somewhere with a normal DNS name.
Sourceforge.net can be a solutions. Update the control/watch files.

2. It seems you use the debian packaging to do the installation of the
files from their build location to the target dirs. Please use "make
install" for that. You can check the fribidi source package for example.

3. Any reason you set the shlibs file manually? You can use
dh_makeshlibs to do that while building. This *will* save you trouble in
the future.

4. I'm not sure about the ranlib and ldconfig in the maintainer scripts.
If needed, the right ldconfig code is created with dh_makeshlibs.

5. The -dev package doesn't have the soname number in it's name. So
that's libjalali-dev. Also drop the provides line. It should also
depends on libjalali0 *with* the same source version... otherwise you
could upgrade only one of the two without the other.

That's it for now. I'll review it again after you'll fix these issues.

Good luck.

Lior Kaplan
kaplan at debian.org

GPG fingerprint:
C644 D0B3 92F4 8FE4 4662  B541 1558 9445 99E8 1DA0

More information about the Debian-arabic-packages mailing list