[Debian-coldfire-devel] linux-2.6.17

[Christian T. Steigies]

On Thu, Jun 22, 2006 at 07:33:38PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Thu, 22 Jun 2006, Geert Uytterhoeven wrote:
> 
> > > > > But linux-image fails here:
> > > > > 
> > > > > arch/m68k/math-emu/fp_scan.S: Assembler messages:
> > > > > arch/m68k/math-emu/fp_scan.S:67: Error: Unknown operator -- statement `getuser.b (%a0),%d0,fp_err_ua1,%a0' ignored
> > > > > arch/m68k/math-emu/fp_scan.S:75: Error: Unknown operator -- statement `getuser.l (%a0)+,%d2,fp_err_ua1,%a0' ignored
> > > > 
> > > > Yep. That's the problem with recent binutils, for which you need the 
> > > > patches I mentioned from Al Viro. I guess I was wrong about binutils-2.16 
> > > > being OK.
> > > 
> > > I have no idea where this comes from. I mostly use 2.15 as cross binutils 
> > > and a few months ago I tested with binutils from CVS without problems. 
> > > Recently I also compiled a kernel with current binutils under m68k also 
> > > with no problems.
> > > So I hope that this was only a temporary problem.
> > 
> > Isn't this the problem where getuser got expanded incorrectly?
> 
> Yes, some kind of macro problem.
> 
> > Didn't you post a patch for that, or am I mistaken? ;-)
> 
> I can't, as I've never reproduced it myself. :)

It is still there, I just built a fresh cross-gcc with bintuils 2.1.17,
gcc-4.1.1, and, after applying one patch, the build fails with getuser
problems. Can we have a patch for the CVS, please?

This patch fixes the first build problem:

  LD      .tmp_vmlinux1
arch/m68k/mm/built-in.o: In function `paging_init':
: undefined reference to `__stop_fixup'
arch/m68k/mm/built-in.o: In function `paging_init':
: undefined reference to `__start_fixup'

I don't know if asm/module.h should be included somewhere else, but this
fixes it for me.

--- a/arch/m68k/mm/motorola.c.orig      2006-06-18 03:49:35.000000000 +0200
+++ b/arch/m68k/mm/motorola.c   2006-06-26 19:29:09.000000000 +0200
@@ -20,6 +20,7 @@
 #include <linux/init.h>
 #include <linux/bootmem.h>

+#include <asm/module.h>
 #include <asm/setup.h>
 #include <asm/uaccess.h>
 #include <asm/page.h>


Christian