[Debian-eeepc-devel] [PATCH] add support for GSM (3G) toggling

[Damyan Ivanov]

I have a small nitpick bout this patch.

-=| Thiemo Nagel, Tue, Jul 21, 2009 at 10:10:34PM +0200 |=-
> [...]
> diff --git a/etc/acpi/actions/gsm.sh b/etc/acpi/actions/gsm.sh
> new file mode 100644
> index 0000000..a16f428
> --- /dev/null
> +++ b/etc/acpi/actions/gsm.sh
> [...]
> +    if echo `cat $RFKILL` > $RFKILL 2> /dev/zero; then

How about changing /dev/zero to /dev/null? I somehow always associate 
/dev/zero with reading, and /dev/null with a black hole.

Really a nitpick, the rest of the patch looks fine to me.

-- 
dam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-eeepc-devel/attachments/20090722/a140e597/attachment.pgp>