[Debian-eeepc-devel] Bug#714644: eeepc-acpi-scripts: initscript produce silly warnings

[Denys Gavrysh]

Package: eeepc-acpi-scripts
Version: 1.1.12
Severity: minor
Tags: patch

Dear Debian Eee PC Team,

Recent Debian kernels have pciehp module as builtin.
But /etc/init.d/eeepc-acpi-scripts is trying to unload the module and complaining
with "FATAL" warning message while system boots up.
For me it is very annoing, because it can mix with lot of other boot process
output, so it's hard to see real problems when they appear.

This patch premoves the warnings if we have pciehp directory in /proc,
but no module available:

--- debian/eeepc-acpi-scripts.init	2011-09-25 08:16:51.000000000 +0300
+++ debian/eeepc-acpi-scripts.init	2013-07-01 17:23:55.082981621 +0300
@@ -67,7 +67,10 @@
     # - kernel 2.6.32 & newer: eeepc-laptop also works on the EeePC 900A
     if [ -d /sys/module/pciehp ]; then
       # Hmm, already present
-      if [ "$KERNEL" -ge 29 -a "`cat /sys/class/dmi/id/product_name`" != "900A" ]; then
+      if ! modinfo pciehp >/dev/null 2>&1
+        # Module pciehp is builtin, do nothing
+        :
+      elif [ "$KERNEL" -ge 29 -a "`cat /sys/class/dmi/id/product_name`" != "900A" ]; then
         # 2.6.29 and newer on all but the EeePC 900A - unload pciehp if loaded
         log_warning_msg 'Module "pciehp" is loaded; trying to unload'
         maybe_warn modprobe -r pciehp


Thanks.