[Debian-eeepc-devel] Bug#714644: Bug#714644: eeepc-acpi-scripts: initscript produce silly warnings

[Denys Gavrysh]

03.07.13 10:36, Domenico Cufalo wrote:
> Thank you very much! I applied this patch and the message about pciehp
> disappeared.
>
> However, during the boot process I can see this message of error:
>
>     /etc/init.d/eeepc-acpi-scripts: 74: /etc/init.d/eeepc-acpi-scripts:
>     Syntax error: "elif" unexpected (expecting "then")


Ah, sorry, missed the ending of line somehow.
This is the correct patch:

--- debian/eeepc-acpi-scripts.init	2011-09-25 08:16:51.000000000 +0300
+++ debian/eeepc-acpi-scripts.init	2013-07-01 17:23:55.082981621 +0300
@@ -67,7 +67,10 @@
     # - kernel 2.6.32 & newer: eeepc-laptop also works on the EeePC 900A
     if [ -d /sys/module/pciehp ]; then
       # Hmm, already present
-      if [ "$KERNEL" -ge 29 -a "`cat /sys/class/dmi/id/product_name`" != "900A" ]; then
+      if ! modinfo pciehp >/dev/null 2>&1; then
+        # Module pciehp is builtin, do nothing
+        :
+      elif [ "$KERNEL" -ge 29 -a "`cat /sys/class/dmi/id/product_name`" != "900A" ]; then
         # 2.6.29 and newer on all but the EeePC 900A - unload pciehp if loaded
         log_warning_msg 'Module "pciehp" is loaded; trying to unload'
         maybe_warn modprobe -r pciehp


-- 
Denys Gavrysh