[Debian-hebrew-package] Bug#722039: Bug#722039: hdate-applet: FTBFS agains evolution-data-server 3.8

[Lior Kaplan]

After sorting the includes (see bellow), the problem is these errors:

ecal-client.c: In function 'get_ecal_events':
ecal-client.c:97:5: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
     g_snprintf (events, max_events_string_length, "");
     ^
ecal-client.c: In function 'open_ecal_calendar':
ecal-client.c:129:3: warning: implicit declaration of function
'e_cal_new_from_uri' [-Wimplicit-function-declaration]
   (*ecal) = e_cal_new_from_uri (uri, E_CAL_SOURCE_TYPE_EVENT);
   ^
ecal-client.c:129:11: warning: assignment makes pointer from integer
without a cast [enabled by default]
   (*ecal) = e_cal_new_from_uri (uri, E_CAL_SOURCE_TYPE_EVENT);
           ^
ecal-client.o: In function `open_ecal_calendar':
/tmp/hdate-applet/hdate-applet-0.15.11/src/ecal-client.c:129: undefined
reference to `e_cal_new_from_uri'

Which really looks like something upstream should take a look at.

To sort includes:

--- hdate-applet-0.15.11.orig/src/ghcal-callbacks.c     2013-09-15
23:10:33.000000000 +0000
+++ hdate-applet-0.15.11/src/ghcal-callbacks.c  2013-09-15
23:24:57.000000000 +0000
@@ -23,8 +23,7 @@
 /* for the evolution calendar */
 #ifdef WITH_EVOLUTION
   #include <stdlib.h>
-  #include <libecal/e-cal.h>
-  #include <libecal/e-cal-time-util.h>
+  #include <libecal/libecal.h>
 #endif

 #include <gtk/gtk.h>

--- hdate-applet-0.15.11.orig/src/ecal-client.h 2010-10-31
19:10:41.000000000 +0000
+++ hdate-applet-0.15.11/src/ecal-client.h      2013-09-15
23:25:38.000000000 +0000
@@ -17,7 +17,7 @@
  */

 /* for the evolution calendar */
-#include <libecal/e-cal.h>
+#include <libecal/libecal.h>

 /* get events for day,month,year from evolution clendar */
 int

--- hdate-applet-0.15.11.orig/src/ecal-client.c 2013-09-15
23:27:03.000000000 +0000
+++ hdate-applet-0.15.11/src/ecal-client.c      2013-09-15
23:27:35.000000000 +0000
@@ -24,7 +24,6 @@
 /* for the evolution calendar */
 #include <stdlib.h>
 #include <libecal/libecal.h>
-#include <libecal/e-cal-time-util.h>

 /* */




On Sat, Sep 7, 2013 at 1:36 AM, <biebl at debian.org> wrote:

> Source: hdate-applet
> Version: 0.15.11-1.1
> Severity: important
> User: pkg-evolution-maintainers at lists.alioth.debian.org
> Usertags: eds-3.8
>
> Hi,
>
> we are planning to upload evolution and evolution-data-server 3.8 to
> unstable soon. Your package hdate-applet declares a build dependency on
> one of these packages:
>
>  evolution-data-server-dev
>  libedataserver1.2-dev
>  libcamel1.2-dev
>  libebook1.2-dev
>  libedataserverui-3.0-dev
>  libedata-book1.2-dev
>  libecal1.2-dev
>  libedata-cal1.2-dev
>  libebackend1.2-dev
>
> During a rebuild, hdate-applet failed to build against
> evolution-data-server 3.8. The build log can be found at [1].
>
> One notable change is, that libedataserverui has been dropped.
> If your package build-depends on libedataserverui-3.0-dev, you'll need
> to get rid of that dependency.
>
> As for some of the other API changes, see the release announcements of
> evolution-data-server 3.5.3 [2].
>
> If you want to test-build hdate-applet, version 3.8 of
> evolution-data-server
> is currently available in experimental.
> If you don't have the time porting to the new e-d-s interfaces, disabling
> e-d-s support (temporarily) might be an option. Otherwise hdate-applet will
> have to be removed from testing to not block the transition.
>
> Ubuntu and Fedora have already done this transition, so it might be
> worthwile having a look at the patches they ship.
>
> Thanks for your cooperation.
>
>
> Michael,
> on behalf of the Debian GNOME and Evolution team.
>
> [1] http://people.debian.org/~biebl/eds-3.8/hdate-applet_0.15.11-1.1.log
> [2]
> https://mail.gnome.org/archives/ftp-release-list/2012-June/msg00100.html
>
> _______________________________________________
> Debian-hebrew-package mailing list
> Debian-hebrew-package at lists.alioth.debian.org
>
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-hebrew-package
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/debian-hebrew-package/attachments/20130916/3c26473a/attachment.html>