[Debian-islamic-commits] [SCM] Zakat Calculator branch, master, updated. upstream/0.2-4-g297266d

[أحمد المحمودي]

On Wed, Dec 29, 2010 at 08:06:23AM +0000, Mahyuddin Susanto wrote:
> +Description: Zakat Calc provide zakat calculations for Muslim
>   A program to predict how much we can spend zakat
> - especially for moslem. Sabily Zakat is a project under
> + especially for moslem. Zakat Calc is a project under
>   Sabily Project

It is not good to have the software name in the short description, 
replace it with some

> +override_dh_auto_clean:
> +	dh_auto_clean

What sort of override is this ?

> +override_dh_auto_configure:
> +	dh_auto_configure -- --exec-prefix=/usr --bindir=/usr/bin LDFLAGS="-Wl,-z,defs"

What's the use of this ? There isn't a configure script with the 
package.

> +override_dh_auto_install:
> +	/usr/bin/gbc2 -a  sabily-zakat
> +	gba2 sabily-zakat
> +	dh_auto_build

1) It would be more sensible that this would go under override_dh_auto_build
2) Why are you calling dh_auto_build after gba2 ? What do you expect it 
to do ?

> diff --git a/debian/watch b/debian/watch
> index f5f6605..f6df806 100644
> --- a/debian/watch
> +++ b/debian/watch
> @@ -1,3 +1,2 @@
>  version=3
> -http://launchpad.net/zakat-calc/+download
> -http://launchpad.net/zakat-calc/.*/zakat-calc-(.*)\.tar\.gz
> +http://sf.net/zakat-calc/Sabily%20Zakat%20Calc-(.+)\.tar\.gz

This does not work, the upstream tarball file name is: 
Sabily-Zakat-(.+)\.tar\.gz not Sabily%20Zakat%20Calc-(.+)\.tar\.gz

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-islamic-commits/attachments/20101229/d3557504/attachment.pgp>