[Debian-olpc-devel] Package Review Request - Moon Activity

[Luke Faraone]

[cc -= sugarteam]

Ishan,

On 09/30/2010 06:19 PM, Manusheel Gupta wrote:
> Please review Moon activity packaged by Ishan -
> http://wiki.debian.org/Sugar/tasks. Kindly share feedback if something is
> missing or incorrect.

In debian/copyright, please check over the package carefully. I noticed
that the copyright for the overall package was listed as "One Laptop Per
Child", and that Gary was listed as the author only of moon.py.

I didn't see anything that indicated the package was at all written by
OLPC employees, so I'm confused as to the source of the message. Please
clarify the rationale, including where the information was taken from,
or remove the notice.

This isn't as important, but while you're at it, you should correct the
license header to point to /usr/share/common-licenses/GPL-2, and "of a
recent version " to "of version 2" for clarity. The wording currently
used is now frowned upon.

Please check your package for compliance with Standards Version 3.9.1.0,
make changes as needed, and increment the value in debian/control.in.
When doing so, please commit that change, *then* regenerate control from
control.in, rather than doing it all in one commit.

See
<http://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt>
for a brief overview of "what's new" in 3.9.1.0.

-- 
╒═════════════════════════════════════════════════════════════════╕
│Luke Faraone                          ╭Debian / Ubuntu Developer╮│
│http://luke.faraone.cc                ╰Sugar Labs, Systems Admin╯│
│PGP: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506          │
╘═════════════════════════════════════════════════════════════════╛

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-olpc-devel/attachments/20101009/22fd603b/attachment.pgp>