[Debian-olpc-devel] review sugar-browse-activity
ishan at seeta.in
Thu Oct 21 19:12:41 UTC 2010
Sorry for the late response.
Thanks for the pointers provided.
I completely agree with you and would like to discuss the changes i intend
to make in the browse activity-:
1. Updated the browse from version '115' to '119'.
2. Bumped the standard version to '126.96.36.199'.
3. Commented the patch "1002_revert_gnome_hack.patch" in the series file as
it gave http://paste.ubuntu.com/517605/ error in build.
I have tested the changes locally and it seems to be working fine.
Wish if you can review the above changes and provide me feedback on any
further changes required.
On Sun, Oct 17, 2010 at 8:54 PM, Jonas Smedegaard <dr at jones.dk> wrote:
> Hi Ishan,
> On Sun, Oct 17, 2010 at 07:59:18PM +0530, Ishan Bansal wrote:
>> I have made a new repository for browse activity , because i thought of
>> getting my changes reviewed first before pushing them directly to the browse
> On Sun, Oct 17, 2010 at 2:18 AM, Jonas Smedegaard <dr at jones.dk> wrote:
>>> On Sat, Oct 16, 2010 at 10:49:23PM +0530, Ishan Bansal wrote:
>>> I have updated the browse activity and made a new git repository as
> [please consider top-writing - it makes quoting difficult to read]
> Ah, I see.
> Creating short-lived gits only for the purpose of review is not a good
> approach in my opinion, though.
> I suggest the following instead:
> 1) if you worry that others here might disagree with your changes,
> then first discuss here on the list what you intend to change,
> before you do work that might be a waste of your time
> 2) check out the main git, and prepare your changes locally
> 3) test your changes locally, that they do what you intended, and
> that the packaging still works properly.
> Preferrably, especially when working on packagings you are not
> normally working on (as is the case with the Browse activity),
> compare your resulting packaging build against latest official
> release of the packaging (e.g. using dget) and compare them
> (e.g. using debdiff).
> 4) if you run into trouble with your work locally, then don't
> hesitate to ask for help here on the list. No questions are
> stupid! Even foolish seeming question, others can learn from!
> If you need to share with us some details of your local changes
> then try attach a patch as attachment to your email to list
> (e.g. using git diff or git log -p).
> 5) when you feel confident that your changes are ok locally, then
> push to the main shared git.
> If we disagree with your changes, they are easy to revert later.
> Or more accurately: simple things are easy to revert.
> Please think twice and strongly consider to ask on the list first
> before you upgrade to a newer upstream release or other changes
> involving adding tags, as they cannot be easily reverted.
> I can't force you, but I would really really appreciate if more of our
> discussions happened here on the list!
> Kind regards,
> - Jonas
>  Info on top-posting:
> * Jonas Smedegaard - idealist & Internet-arkitekt
> * Tlf.: +45 40843136 Website: http://dr.jones.dk/
> [x] quote me freely [ ] ask before reusing [ ] keep private
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> -----END PGP SIGNATURE-----
> Debian-olpc-devel mailing list
> Debian-olpc-devel at lists.alioth.debian.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Debian-olpc-devel