HI jonas and others :) ,<br><br>I agree with you and will try to mention the the sources as well. Well in this case, i have merely mentioned the pointers this time around but i will make sure in future that i try to include what you have mentioned :) .<br>
Thanks for pointing that out.<br><br><br>Regards,<br>Ankur<br><br><div class="gmail_quote">On Tue, Aug 10, 2010 at 4:39 AM, Jonas Smedegaard <span dir="ltr"><<a href="mailto:dr@jones.dk" target="_blank">dr@jones.dk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi all,<br>
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
From: *Ankur Khurana* <<a href="mailto:ankur@seeta.in" target="_blank">ankur@seeta.in</a> <mailto:<a href="mailto:ankur@seeta.in" target="_blank">ankur@seeta.in</a>>><br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Review of activity based on commit:on initial commit:<br>
1.There is no pristine branch.When pushing use --all after git push and before the address to be pushed.I have updated the google doc, please take a look at it as well.<br>
</blockquote>
[...and some more comments, snippet here]<br>
<br>
The points reaised in the review are all good.<br>
<br>
I do suggest, however, to try include more "source" too.<br>
<br>
I mean, in addition to describing what specifically needs changed, also mention why, more generally. Either elaborate on reasoning in your own words or refer to some URL for more info.<br>
<br>
That way the reviews encourage learning in the art of packaging rather than just adding to a big pile of seemingly independent pieces to memorize.<br>
<br>
<br>
My reviews tend include too little specific details. Others, including the above quoted, in my opinion includes too little background info. Ideally they should contain both, I believe: specific details *and* (references to) background info. :-)<br>
<br>
<br>
- Jonas<br><font color="#888888">
<br>
-- <br>
* Jonas Smedegaard - idealist & Internet-arkitekt<br>
* Tlf.: +45 40843136 Website: <a href="http://dr.jones.dk/" target="_blank">http://dr.jones.dk/</a><br>
<br>
[x] quote me freely [ ] ask before reusing [ ] keep private<br>
</font><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.10 (GNU/Linux)<br>
<br>
iQIcBAEBCgAGBQJMYIqaAAoJECx8MUbBoAEhNb4P/3/gjO4lj9vL22Sl0NmUHoWe<br>
CPk3ebdIaFn5INarpZhj5YGJYG2hVbAsxveznhieLoTVFSypyPjBXNjn2BMEzQOV<br>
GUsTnFaxpZVe/8E92Ar6Vbqw+ZacFX7HDKMhkublzQaNvalbd/XaQNgJi8EiuU22<br>
x8Au3QZSXTa/tJR498Mwb2yYRFl09lsa2vp70bJvgn03oFERMqSFE6L2Ewx26cjl<br>
KXUb/R0HLnrGYB2ClqEDVfBBCRwCGFO+XSfTKnxEHVpNKamPZHE0kfxeJQLHXf5d<br>
wwOex3jGrpC2Ku+ZTOwpmD1tcXFwbrkOK6/cbhB/4rdI/8xbT2oKcn1z7F5uOUre<br>
IBBQzcsb2ckMO7PpLogzTAHnx1sp8EcZcxdw8zxtOOOUABWTEBZUIW29cWJJXOtV<br>
IIoBEyxysUd5EdWr03ZKivg4Ja+2D50Kd/fVgyPehZxhVT13pLpnCb0nX9+P9mpa<br>
PYNzKD2bnGefF8JgfDCDt5yK46hKZyAkDBQuWdzV9cI2ziukCmmGPEmdFTqrGj6D<br>
4KoXE5lVinQ/SwesQyOLTp8425RhTVl6Enpei73TllYKZr6Rykvie9sVN7ERm4g9<br>
+8qgRYlCnHHMUTM2Cc+JD8RlL/ITrk3Qpw3D/YUeZ1Ag3+lJeur5v6kluDQy0zYR<br>
bylIpbIaYGseOjSgz5as<br>
=cSrV<br>
-----END PGP SIGNATURE-----<br>
<br>_______________________________________________<br>
Debian-olpc-devel mailing list<br>
<a href="mailto:Debian-olpc-devel@lists.alioth.debian.org" target="_blank">Debian-olpc-devel@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/mailman/listinfo/debian-olpc-devel" target="_blank">http://lists.alioth.debian.org/mailman/listinfo/debian-olpc-devel</a><br>
<br></blockquote></div><br>