Hi Jonas <br><br>Sorry for the late response.<br><br>Thanks for the pointers provided.<br><br>I completely agree with you and would like to discuss the changes i intend to make in the browse activity-:<br><br>1. Updated the browse from version '115' to '119'.<br>
<br>2. Bumped the standard version to '3.9.1.0'.<br><br>3. Commented the patch "1002_revert_gnome_hack.patch" in the series file as it gave <a href="http://paste.ubuntu.com/517605/">http://paste.ubuntu.com/517605/</a> error in build.<br>
<br>I have tested the changes locally and it seems to be working fine.<br><br>Wish if you can review the above changes and provide me feedback on any further changes required.<br><br>Regards<br><br>ishan<br><br><br><div class="gmail_quote">
On Sun, Oct 17, 2010 at 8:54 PM, Jonas Smedegaard <span dir="ltr"><<a href="mailto:dr@jones.dk">dr@jones.dk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Ishan,<div class="im"><br>
<br>
On Sun, Oct 17, 2010 at 07:59:18PM +0530, Ishan Bansal wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I have made a new repository for browse activity , because i thought of getting my changes reviewed first before pushing them directly to the browse repository.<br>
</blockquote>
<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
On Sun, Oct 17, 2010 at 2:18 AM, Jonas Smedegaard <<a href="mailto:dr@jones.dk" target="_blank">dr@jones.dk</a>> wrote:<br>
</div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
On Sat, Oct 16, 2010 at 10:49:23PM +0530, Ishan Bansal wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I have updated the browse activity and made a new git repository as sugar-browser-activity.<br>
<br>
</blockquote>
<br>
Why?<br>
</blockquote></div></blockquote>
<br>
[please consider top-writing[1] - it makes quoting difficult to read]<br>
<br>
Ah, I see.<br>
<br>
Creating short-lived gits only for the purpose of review is not a good approach in my opinion, though.<br>
<br>
I suggest the following instead:<br>
<br>
1) if you worry that others here might disagree with your changes,<br>
then first discuss here on the list what you intend to change,<br>
before you do work that might be a waste of your time<br>
<br>
2) check out the main git, and prepare your changes locally<br>
<br>
3) test your changes locally, that they do what you intended, and<br>
that the packaging still works properly.<br>
Preferrably, especially when working on packagings you are not<br>
normally working on (as is the case with the Browse activity),<br>
compare your resulting packaging build against latest official<br>
release of the packaging (e.g. using dget) and compare them<br>
(e.g. using debdiff).<br>
<br>
4) if you run into trouble with your work locally, then don't<br>
hesitate to ask for help here on the list. No questions are<br>
stupid! Even foolish seeming question, others can learn from!<br>
If you need to share with us some details of your local changes<br>
then try attach a patch as attachment to your email to list<br>
(e.g. using git diff or git log -p).<br>
<br>
5) when you feel confident that your changes are ok locally, then<br>
push to the main shared git.<br>
If we disagree with your changes, they are easy to revert later.<br>
Or more accurately: simple things are easy to revert.<br>
Please think twice and strongly consider to ask on the list first<br>
before you upgrade to a newer upstream release or other changes<br>
involving adding tags, as they cannot be easily reverted.<br>
<br>
<br>
I can't force you, but I would really really appreciate if more of our discussions happened here on the list!<br>
<br>
<br>
Kind regards,<br>
<br>
- Jonas<br>
<br>
<br>
[1] Info on top-posting: <a href="https://secure.wikimedia.org/wikipedia/en/wiki/TOFU" target="_blank">https://secure.wikimedia.org/wikipedia/en/wiki/TOFU</a><div><div></div><div class="h5"><br>
<br>
-- <br>
* Jonas Smedegaard - idealist & Internet-arkitekt<br>
* Tlf.: +45 40843136 Website: <a href="http://dr.jones.dk/" target="_blank">http://dr.jones.dk/</a><br>
<br>
[x] quote me freely [ ] ask before reusing [ ] keep private<br>
</div></div><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.10 (GNU/Linux)<br>
<br>
iQIcBAEBCgAGBQJMuxUQAAoJECx8MUbBoAEhHokP+QHdTZialvUQ+yVq80jZua97<br>
kNs3P1txyYvi4rQWbwT7nnT8HPEV7b8KWP9eGsDrRNPTwx06OghTBVAY3LHnh3RL<br>
rrgSGgg8BrOh/ES5EWMy53BCZKvupn5S1qFAIs13xEIfGWf596MChEXjno8ag++a<br>
Vql4pnoFxYyWQmo4TqqXvoHg5KC/hNR9H7bCPB4mr81JrxrbPmb8jNrUFhF8NmD6<br>
M5PY4dGHz2s7LvP7ywoPMJf7/IW37rjeQ/xXRAcdnKEsj/O36npGYLywPsaLkNtw<br>
+3rCmnJpW9SqkqLla9nw/y+KjRPtnwv9P1ztCoJ896H5w2Q1mGmu1bOqeAj10o7n<br>
Kv5dJ84EeAh9amqSJ7la2IqKHnqPPQ6phIDAm4UKCd7CEVrQSfqivO/RcAJiqbdV<br>
9Q65YkrRTdlK6RW7B4BSuzjL9bnLQPrHtmrXxgSHwTznHh+VhnUM8wJ79YVB9EGX<br>
tG3d75OnRxt/rawf6U+pmBwaQhrMNtWXFefkxkORvmqs1JBB2XBJ+5ex3LgFzo0i<br>
wrNxDbqHJVqQWVKy4g7DgtKso8dgPMubj9zehbg8SzzshgAc8lDvrN3fPE9tZO2j<br>
hX9xm48rPMZ3VmeTAa4rQqxHgPwHBFkCWLTLlR4guJxec6rJD1xqbSRECW4OIGEH<br>
CmiVMu5zubL31d46r49q<br>
=Bjx8<br>
-----END PGP SIGNATURE-----<br>
<br>_______________________________________________<br>
Debian-olpc-devel mailing list<br>
<a href="mailto:Debian-olpc-devel@lists.alioth.debian.org">Debian-olpc-devel@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/mailman/listinfo/debian-olpc-devel" target="_blank">http://lists.alioth.debian.org/mailman/listinfo/debian-olpc-devel</a><br>
<br></blockquote></div><br>