[Debian-ports-devel] Bug#865470: include debian-ports-archive-keyring on non released architectures

[John Paul Adrian Glaubitz]

On 06/21/2017 09:15 PM, jhcha54008 wrote:
> +## Port architectures need their archive keyring
> +UNRELEASED_PORT_ARCHITECTURES=alpha hppa hurd-i386 m68k ppc64 powerpcspe sh4 sparc64 x32
> +ifneq (,$(filter $(UNRELEASED_PORT_ARCHITECTURES),$(ARCHES)))
> +export BASE_INCLUDE := $(BASEDIR)/data/base_include_port_architectures $(BASE_INCLUDE)
> +endif
> +

I was just reviewing your patch and then I realized that Steve already merged it.

There is one issue that I found which is that you added "hurd-i386" to the list
above. However, hurd-i386 is not using the Ports FTP server but the official
FTP servers. Hence, we do not need to include it in this list as it doesn't need
the Debian Ports keyring.  There are remnants of hurd-i386 on the Debian Ports
FTP server, but those files are outdated and I have already asked Aurelien Jarno
to remove them.

> -				BINCLUDE=`[ -n "$(BASE_INCLUDE)" ] && cat $(BASE_INCLUDE) | tr "\n" "," | sed 's!,$$!!g'`; \
> +				BINCLUDE=`[ -n "$(BASE_INCLUDE)" ] && cat $(BASE_INCLUDE) | sort -u | tr "\n" "," | sed 's!,$$!!g'`; \

I'm not sure I understand why you added the additional "sort -u" here. Is the order
of packages important? Did you get an error when building a CD without it?

> --- /dev/null
> +++ b/data/base_include_port_architectures
> @@ -0,0 +1 @@
> +debian-ports-archive-keyring

I think that should be "base_include_ports_architectures" with an "s", same above.

Thanks for fixing this issue. This has been on my TODO list for quite some time!

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913