[SCM] Gerris Flow Solver branch, upstream, updated. b3aa46814a06c9cb2912790b23916ffb44f1f203

[Stephane Popinet]

The following commit has been merged in the upstream branch:
commit d686a6834c1ddb3c4a97d978349d09d69f6774e8
Author: Stephane Popinet <popinet at users.sf.net>
Date:   Wed Jan 16 08:52:23 2008 +1100

    Various 'fixme' comments
    
    darcs-hash:20080115215223-d4795-404c165cd6832158538b3655660a2a5562b9ff32.gz

diff --git a/src/domain.c b/src/domain.c
index fa67049..a5e8093 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -2924,6 +2924,10 @@ guint gfs_domain_tag_droplets (GfsDomain * domain,
 			       GfsVariable * c,
 			       GfsVariable * tag)
 {
+  /* fixme: this function may not work as expected for parallel domain
+     and/or periodic boundaries: droplets sitting on PE boundaries
+     will be seen as two independent droplets... */
+
   g_return_val_if_fail (domain != NULL, 0);
   g_return_val_if_fail (c != NULL, 0);
   g_return_val_if_fail (tag != NULL, 0);
@@ -2999,6 +3003,7 @@ void gfs_domain_remove_droplets (GfsDomain * domain,
       guint * tmp = g_malloc (p.n*sizeof (guint));
       memcpy (tmp, p.sizes, p.n*sizeof (guint));
       qsort (tmp, p.n, sizeof (guint), greater);
+      /* fixme: this won't work for parallel jobs */
       p.min = tmp[-1 - min];
       g_free (tmp);
     }
diff --git a/src/solid.c b/src/solid.c
index 717d8b1..40a822a 100644
--- a/src/solid.c
+++ b/src/solid.c
@@ -1088,6 +1088,7 @@ static void restore_solid (FttCell * cell, gpointer * data)
     *not_cut = FALSE;
   }
   else if (GFS_VARIABLE (cell, status->i) == 0.) {
+    /* fixme: this can fail for non-contiguous domains (e.g. non-connected GfsBoxes) */
     g_assert (*not_cut);
     GFS_VARIABLE (cell, c->i) = 0.;
   }

-- 
Gerris Flow Solver