[SCM] polybori: Polynomials over Boolean Rings branch, master, updated. upstream/0.8.2-43-ga0b8628

Picca Frédéric-Emma?==?UTF-8?Q?nuel picca at debian.org
Sat Jan 5 19:37:38 UTC 2013


The following commit has been merged in the master branch:
commit a0b8628c2fe5e3aee571f2a26f82664859e02776
Author: Picca Frédéric-Emmanuel <picca at debian.org>
Date:   Sat Jan 5 17:36:03 2013 +0100

    add the todo file

diff --git a/debian/todo b/debian/todo
new file mode 100644
index 0000000..da0461c
--- /dev/null
+++ b/debian/todo
@@ -0,0 +1,131 @@
+packaging
+---------
+
+- please remove DM-Upload-Allowed: yes.
+  the procedure changed.
+
+- full license check with at least licensecheck. Each file of the
+  package should have the right copyright informations. (this is also
+  why embedded libraries is a pain)
+
+- 0005_PolyGUI.patch was commited applyed into the master branch. It
+  would be nice to use gbp-pq to produce the patch series.
+
+- deal with all remaining bugs from debbug
+
+- replace Pre-Depends: multiarch-support by Pre-Depends:
+  ${misc:Pre-Depends}
+
+- add Multi-Arch: same where needed. libpolybori-0.8-2,
+  libpolybori-groebner-0.8-2
+
+- add Pre-Depends and Multi-Arch to -dev packages and also the -dbg
+  one
+
+- if ipbori could be replace by an ipython profile, maybe install this
+  profile under python-polybori binary package and remove the polybori
+  package.
+
+- check that the changelog is ok, 0.8-0, 0.8.2-1~exp0 and 0.8.2-1~exp1
+  but I have no trace of those 0.8-0 and 0.8.2-1~exp0 into the Debian
+  archive. So fix this by merging the three entries into only one.
+  0.8.2-1~exp1 and target experimental instead of unstable
+
+- remove libpolybori-0.5.0-0.install from the repository
+  (maybe this is just in my own repo ;)
+
+- please use the same name for the symbol files and the the library one.
+  libpolybori-0.8.symbols -> libpolybori-0.8-2.symbols
+  idem for the other library.
+
+- in the symbols files you use the wrong version number
+   _Z10error_textP15pbori_DdManager at Base 0.8 this should be the
+   package version (changelog) without the debian version. In your
+   case 0.8.2
+
+- instread of
+ override_dh_strip:
+        dh_strip --exclude=groebner --exclude=PyPolyBoRi -plibpolybori-dev --dbg-package=libpolybori-dbg -a
+        dh_strip --exclude=PyPolyBoRi -plibpolybori-groebner-dev  --dbg-package=libpolybori-groebner-dbg -a
+        dh_strip -ppython-polybori -a
+
+ can you use this
+ override_dh_strip:
+	dh_strip -plibpolybori-0.8-2 --dbg-package=libpolybori-0.8-2-dbg
+	dh_strip -plibpolybori-groebner-0.8-2 --dbg-package=libpolybori-groebner-0.8-2-dbg
+	dh_strip -a -Nlibpolybori-0.8-2 -Nlibpolybori-groebner-0.8-2
+
+ this seems to me cleaner. (beware to use the right -dbg package name
+ and change them in the control file).
+
+- once done with the control file it would be very good to check with
+  debian-l10n-english for it's correctness. You can send an email to
+  this mailing list (I do not remember exactly the name but you can
+  find it bu googling), asking for a review of your package (attach
+  the control file and the git repository location). there is english
+  natives which can help and improve a lot the description of the
+  package. It helps me a lot before.
+
+- Build-Depends: debhelper (>= 9),
+               patchutils,
+               scons,
+               python-setuptools,
+               libboost-dev,
+               libboost-python-dev,
+               doxygen,
+               hevea | tex4ht,
+               python-all-dev
+
+ it seems to me that libboost-dev, patchutils are useless
+
+ python-setuptools should be avoid if
+ build-python%: PYTHONSITE=`/usr/bin/python$* -c 'import setuptools; print setuptools.distutils.sysconfig.get_python_lib() '`
+
+ distutils where use instead
+ build-python%: PYTHONSITE=`/usr/bin/python$* -c 'import distutils.sysconfig; print distutils.sysconfig.get_python_lib() '`
+
+ you depends of hevea | tex4ht is it used by doxygen ?, if not you can remove it
+
+- your package provide a arch: all package.  it would be nice in that
+  case to create an indep part like this one:
+
+               #!/usr/bin/make -f
+               %:
+                       dh $@
+
+               override_dh_auto_build-indep:
+                       $(MAKE) -C docs
+
+               # Aucun test nécessaire pour la documentation
+               override_dh_auto_test-indep:
+
+               override_dh_auto_install-indep:
+                       $(MAKE) -C docs install
+
+ this exemple is taken from the dh manpage. but in your case it seems
+ that you need to avoid compiling the documentation from scons.  then
+ you should create a Build-Dep-Indep: doxygen, hevea | tex4ht this is
+ better when it comes to do binary NMU. the arch all part is not
+ modified.
+
+upstream
+--------
+
+- remove the embeded M4RI
+
+- Cudd package or not package ?
+
+- some part of the python code do not follow the pep8 recommendations.
+  indented with 2 spaces instead of 4.
+
+- why not using QtDesigner instead of hard coding the ui part ?
+
+- ipbori can be an ipython profile instead of a dedicated binary ?
+
+- integrate the .desktop file in the upstream installation process.
+  this way it can be usefull to other distributions.
+
+- rename polybori.pc into polybori-0.8.pc this is much more consistant
+  with the current naming schema. idem for the other library.
+
+- maybe add an option for the documentation compilation only.
\ No newline at end of file

-- 
polybori: Polynomials over Boolean Rings



More information about the debian-science-commits mailing list