[polybori] 01/01: Protect CErrorInfo::text() against invalid array access.

[Tobias Hansen]

This is an automated email from the git hooks/post-receive script.

thansen pushed a commit to branch master
in repository polybori.

commit 2e5d71935dd0ca0a1868ee1f1a533c7aca319ccc
Author: Tobias Hansen <tobias.han at gmx.de>
Date:   Sun Nov 3 22:30:58 2013 +0100

    Protect CErrorInfo::text() against invalid array access.
---
 debian/changelog                                       |    7 +++++++
 ...-Protect-CErrorInfo-from-invalid-array-access.patch |   16 ++++++++++++++++
 debian/patches/series                                  |    1 +
 3 files changed, 24 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 55673ba..d3bb034 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+polybori (0.8.3-2) unstable; urgency=low
+
+  * Protect CErrorInfo::text() against invalid array access.
+    The missing check caused failing tests on ia64 and alpha.
+
+ -- Tobias Hansen <thansen at debian.org>  Sun, 03 Nov 2013 22:27:53 +0100
+
 polybori (0.8.3-1) unstable; urgency=low
 
   * Add myself to Uploaders with ack from Alexander Dreyer.
diff --git a/debian/patches/0003-Protect-CErrorInfo-from-invalid-array-access.patch b/debian/patches/0003-Protect-CErrorInfo-from-invalid-array-access.patch
new file mode 100644
index 0000000..d5620e7
--- /dev/null
+++ b/debian/patches/0003-Protect-CErrorInfo-from-invalid-array-access.patch
@@ -0,0 +1,16 @@
+Description: Protect CErrorInfo::text() against invalid array access
+ * The test suite tests this in PBoRiErrorTest.cc, but the tests
+   failed only on the ia64 and alpha architectures.
+Author: Tobias Hansen <thansen at debian.org>
+
+--- a/libpolybori/src/CErrorInfo.cc
++++ b/libpolybori/src/CErrorInfo.cc
+@@ -47,7 +47,7 @@
+ CErrorInfo::text(errornum_type num) {
+ 
+   PBORI_TRACE_FUNC( "CErrorInfo::text(errornum_type) const" );
+-  if PBORI_UNLIKELY(num > CTypes::last_error)
++  if PBORI_UNLIKELY(num < 0 || num > CTypes::last_error)
+     return "Unknown error occured.";
+ 
+   return pErrorText[num];
diff --git a/debian/patches/series b/debian/patches/series
index 906f230..f1bdd24 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 0001-Added-libraries-symlinks-to-testsuite-dependencies-t.patch
 0002-Generate-clean-.pc-files-from-upstream.patch
+0003-Protect-CErrorInfo-from-invalid-array-access.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/polybori.git