[mlpack] 315/324: When Conrad took the patch, he stripped out a lot of compatibility between iterators, so... take the tests depending on that functionality out.

Barak A. Pearlmutter barak+git at cs.nuim.ie
Sun Aug 17 08:22:22 UTC 2014


This is an automated email from the git hooks/post-receive script.

bap pushed a commit to branch svn-trunk
in repository mlpack.

commit da2f8badc07fd87ad5cd9932c497c4806194c84b
Author: rcurtin <rcurtin at 9d5b8971-822b-0410-80eb-d18c1038ef23>
Date:   Thu Aug 14 16:23:25 2014 +0000

    When Conrad took the patch, he stripped out a lot of compatibility between
    iterators, so... take the tests depending on that functionality out.
    
    
    git-svn-id: http://svn.cc.gatech.edu/fastlab/mlpack/trunk@17028 9d5b8971-822b-0410-80eb-d18c1038ef23
---
 src/mlpack/tests/arma_extend_test.cpp | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/mlpack/tests/arma_extend_test.cpp b/src/mlpack/tests/arma_extend_test.cpp
index 67c8cd9..6bc7dff 100644
--- a/src/mlpack/tests/arma_extend_test.cpp
+++ b/src/mlpack/tests/arma_extend_test.cpp
@@ -35,8 +35,6 @@ BOOST_AUTO_TEST_CASE(InplaceReshapeColumnTest)
  * Make sure we can reshape a large matrix.
  */
 BOOST_AUTO_TEST_CASE(InplaceReshapeMatrixTest)
-{
-  arma::mat X;
   X.randu(8, 10);
   arma::mat oldX = X;
 
@@ -92,8 +90,6 @@ BOOST_AUTO_TEST_CASE(ConstRowColIteratorTest)
   } while (it != X.begin_row_col());
 
   BOOST_REQUIRE_EQUAL(count, 0);
-  // make sure it can be constructed from row_iterator
-  it = X.begin_row(0);
 }
 
 /**
@@ -140,9 +136,6 @@ BOOST_AUTO_TEST_CASE(RowColIteratorTest)
   } while (it != X.begin_row_col());
 
   BOOST_REQUIRE_EQUAL(count, 0);
-
-  // Make sure it can be constructed from row_iterator.
-  it = X.begin_row(0);
 }
 
 /**
@@ -151,18 +144,18 @@ BOOST_AUTO_TEST_CASE(RowColIteratorTest)
 BOOST_AUTO_TEST_CASE(MatRowColIteratorDecrementOperatorTest)
 {
   mat test = ones<mat>(5, 5);
-  
+
   mat::row_col_iterator it1 = test.begin_row_col();
   mat::row_col_iterator it2 = it1;
-  
-  // check that postfix-- does not decrement the position when position is pointing
-  // to the begining
+
+  // check that postfix-- does not decrement the position when position is
+  // pointing to the begining
   it2--;
   BOOST_REQUIRE_EQUAL(it1.row(), it2.row());
   BOOST_REQUIRE_EQUAL(it1.col(), it2.col());
-  
-  // check that prefix-- does not decrement the position when position is pointing
-  // to the begining
+
+  // check that prefix-- does not decrement the position when position is
+  // pointing to the begining
   --it2;
   BOOST_REQUIRE_EQUAL(it1.row(), it2.row());
   BOOST_REQUIRE_EQUAL(it1.col(), it2.col());

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/mlpack.git



More information about the debian-science-commits mailing list