[apophenia] 01/01: hidden serious bug - eg/t_test_by_rows - fix

[Jerome Benoit]

This is an automated email from the git hooks/post-receive script.

calculus-guest pushed a commit to branch master
in repository apophenia.

commit 84ed180b360efebcb79875ee2000c8326134a93b
Author: Jerome Benoit <calculus at rezozer.net>
Date:   Fri Oct 16 02:14:12 2015 +0200

    hidden serious bug - eg/t_test_by_rows - fix
---
 debian/changelog                                   |  7 ++++++
 debian/patches/series                              |  1 +
 .../patches/upstream-typo-eg_t_test_by_rows.patch  | 26 ++++++++++++++++++++++
 3 files changed, 34 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index bff69ae..cefcba0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+apophenia (0.999e+ds-4) UNRELEASED; urgency=medium
+
+  * bug fix release:
+    - eg/t_test_by_rows TYPO and hidden numerical FAILURE, isolate and fix.
+
+ -- Jerome Benoit <calculus at rezozer.net>  Fri, 16 Oct 2015 00:08:20 +0000
+
 apophenia (0.999e+ds-3) unstable; urgency=medium
 
   * RC bug fix release (Closes: #793998):
diff --git a/debian/patches/series b/debian/patches/series
index cd675a5..8955cff 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
+upstream-typo-eg_t_test_by_rows.patch
 upstream-bug-793998-eg_test_updating.patch
 upstream-bug-793998-tests_distribution_tests.patch
 debianization.patch
diff --git a/debian/patches/upstream-typo-eg_t_test_by_rows.patch b/debian/patches/upstream-typo-eg_t_test_by_rows.patch
new file mode 100644
index 0000000..3541cf0
--- /dev/null
+++ b/debian/patches/upstream-typo-eg_t_test_by_rows.patch
@@ -0,0 +1,26 @@
+Description: upstream -- typo -- eg/t_test_by_rows
+ Fix a faulty left parenthesis that had hidden a serious numerical bug.
+ The so raised bug has been submitted alongside to the upstream maintainer:
+ the numerical fix was provided by him.
+Origin: debian/upstream
+Author:
+ Jerome Benoit <calculus at rezozer.net>
+ Ben Klemens <fluffmail at f-m.fm>
+Last-Update: 2015-10-16
+Comment:
+ The typo and the raised numerical issue were isolated by Jerome Benoit on
+ behalf of the Debian Science Team; the numerical fix was provided by Ben
+ Klemens as upstream maintainer.
+
+--- a/eg/t_test_by_rows.c
++++ b/eg/t_test_by_rows.c
+@@ -32,7 +32,7 @@
+         assert(apop_data_get(means, i, -1) * apop_data_get(tstats, i, -1) >=0);
+ 
+         //inverse of P-value should be the t statistic.
+-        assert(fabs(gsl_cdf_tdist_Pinv(apop_data_get(confidences, i, -1),100) 
+-                    - apop_data_get(tstats, i, -1) < 1e-3));
++        assert(fabs(gsl_cdf_tdist_Pinv(apop_data_get(confidences, i, -1), 99)
++                    - apop_data_get(tstats, i, -1)) < 1e-5);
+     }
+ }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/apophenia.git