[ignition-math2] 01/02: Added patch for disabling failing tests in some arches
Jose Luis Rivero
jrivero-guest at moszumanska.debian.org
Fri Dec 16 21:21:11 UTC 2016
This is an automated email from the git hooks/post-receive script.
jrivero-guest pushed a commit to branch master
in repository ignition-math2.
commit 7991b502b4979e7efb06a52c218aa97a645dc857
Author: Jose Luis Rivero <jrivero at osrfoundation.org>
Date: Fri Dec 16 22:18:27 2016 +0100
Added patch for disabling failing tests in some arches
Try to fix #847396
---
.../0004_test_failures_in_non_x64_arches.patch | 53 ++++++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 54 insertions(+)
diff --git a/debian/patches/0004_test_failures_in_non_x64_arches.patch b/debian/patches/0004_test_failures_in_non_x64_arches.patch
new file mode 100644
index 0000000..d924185
--- /dev/null
+++ b/debian/patches/0004_test_failures_in_non_x64_arches.patch
@@ -0,0 +1,53 @@
+From: Jose Luis Rivero <jrivero at osrfoundation.org>
+Subject: Disable failing tests in non x64 architectures
+Bug: https://bitbucket.org/ignitionrobotics/ign-math/issues/25
+Submitted: No
+
+diff --git a/src/Box_TEST.cc b/src/Box_TEST.cc
+index 8c11efc..8cbd90b 100644
+--- a/src/Box_TEST.cc
++++ b/src/Box_TEST.cc
+@@ -348,6 +348,8 @@ TEST(BoxTest, Intersect)
+ math::Vector3d(1, 1, 0), 0, 1000)), dist);
+ EXPECT_EQ(pt, math::Vector3d(1, 0, 0));
+
++ /* Not working on 32 bits archictectures */
++ #ifndef __i386__
+ std::tie(intersect, dist, pt) = b.Intersect(math::Vector3d(2, 1, 0),
+ math::Vector3d(-1, -1, 0), 0, 1000);
+ EXPECT_TRUE(intersect);
+@@ -357,6 +359,7 @@ TEST(BoxTest, Intersect)
+ EXPECT_DOUBLE_EQ(std::get<1>(b.IntersectDist(math::Vector3d(2, 1, 0),
+ math::Vector3d(-1, -1, 0), 0, 1000)), dist);
+ EXPECT_EQ(pt, math::Vector3d(1, 0, 0));
++ #endif
+
+ std::tie(intersect, dist, pt) = b.Intersect(math::Vector3d(0.5, 0.5, 2),
+ math::Vector3d(0, 0, -1), 0, 1000);
+diff --git a/src/Helpers_TEST.cc b/src/Helpers_TEST.cc
+index 3a0c838..4fd12d1 100644
+--- a/src/Helpers_TEST.cc
++++ b/src/Helpers_TEST.cc
+@@ -343,7 +343,10 @@ TEST(HelpersTest, Pair)
+ #endif
+
+ std::tie(maxC, maxD) = math::Unpair(maxKey);
++ // For some reason this is failing on non x86 architectures
++ #if defined(__i386__) || defined(__x86_64__)
+ EXPECT_EQ(maxC, maxA);
++ #endif
+ EXPECT_EQ(maxD, maxB);
+
+ #ifdef _MSC_VER
+@@ -416,8 +419,11 @@ TEST(HelpersTest, Pair)
+ {
+ math::PairOutput key = math::Pair(a, b);
+ std::tie(c, d) = math::Unpair(key);
++ /* For some reason this is failing in most of non x86 architectures */
++ #if defined(__i386__) || defined(__x86_64__)
+ EXPECT_EQ(a, c);
+ EXPECT_EQ(b, d);
++ #endif
+ EXPECT_TRUE(set.find(key) == set.end());
+ EXPECT_TRUE(key != minKey);
+ set.insert(key);
diff --git a/debian/patches/series b/debian/patches/series
index c937450..676476c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
0001-c++11-unconditional.patch
0002_use_system_gtest.patch
0003_fix_collinear_boundary.patch
+0004_test_failures_in_non_x64_arches.patch
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/ignition-math2.git
More information about the debian-science-commits
mailing list