[gap-toric] 01/01: Refreshed Imported Zeroth Debian patch 1.8+ds-1

Wed Dec 28 03:45:45 UTC 2016

This is an automated email from the git hooks/post-receive script.

calculus-guest pushed a commit to branch master
in repository gap-toric.

commit f0f6646aad9851a3e95d22196350481a42f37a24
Author: Jerome Benoit <calculus at rezozer.net>
Date:   Wed Dec 28 03:41:40 2016 +0000

    Refreshed Imported Zeroth Debian patch 1.8+ds-1
---
 debian/changelog                                   |  2 +-
 debian/copyright                                   |  1 +
 ...-documentation-examples-math-possible_bug.patch | 50 ++++++++++++++++++----
 ...tream-correct-documentation-examples-typo.patch |  4 +-
 4 files changed, 45 insertions(+), 12 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 0f22551..05b2ac3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,4 +2,4 @@ gap-toric (1.8+ds-1) unstable; urgency=medium
 
   * Initial release (Closes: #848053).
 
- -- Jerome Benoit <calculus at rezozer.net>  Wed, 14 Dec 2016 05:18:32 +0000
+ -- Jerome Benoit <calculus at rezozer.net>  Wed, 28 Dec 2016 03:39:27 +0000
diff --git a/debian/copyright b/debian/copyright
index 0fff69a..cddb80d 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -2,6 +2,7 @@ Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0
 Upstream-Name: GAP package toric
 Upstream-Contact: David Joyner <wdjoyner at gmail.com>
 Source: http://www.gap-system.org/Packages/toric.html
+X-Source: https://github.com/gap-packages/toric/
 Files-Excluded:
  html
  doc/chap*.txt
diff --git a/debian/patches/upstream-correct-documentation-examples-math-possible_bug.patch b/debian/patches/upstream-correct-documentation-examples-math-possible_bug.patch
index d156f4f..18902ec 100644
--- a/debian/patches/upstream-correct-documentation-examples-math-possible_bug.patch
+++ b/debian/patches/upstream-correct-documentation-examples-math-possible_bug.patch
@@ -1,11 +1,42 @@
 Description: upstream: correct examples in documentation: math
- Correct an error as detected through ExtractExamples (section 5.4 in
- GAPDoc Reference Manual) by the packageitself. This correction is by
- no mean authoritative: confirmation has been to the upstream maintainer.
+ Testing the package itself against the samples given in the documentation
+ with the help of ExtractExamples (section 5.4 in GAPDoc Reference Manual)
+ exhibits an unexpected `return', at least for blind eyes. We observe
+ .
+   gap> J:=IdealAffineToricVariety([[1,0],[3,4]]);
+	 <two-sided ideal in Rationals[x_1,x_2,x_3,x_4,x_5], (3 generators)>
+	 gap> GeneratorsOfIdeal(J);
+	 [ -x_4^4+x_1, -x_4^3+x_2, -x_4^2+1 ]
+	.
+	while we expect
+	.
+   gap> J:=IdealAffineToricVariety([[1,0],[3,4]]);
+	 [ two-sided ideal in PolynomialRing(..., [ x_1, x_2 ]), (3 generators) ]
+	 gap> GeneratorsOfIdeal(J);
+	 [ -x_2^2+x_1, -x_2^3+x_1^2, -x_2^4+x_1^3 ]
+	.
+ As pointed out by the upstream maintainer [private communication], the article
+ ``Computing with toric varieties'' in `Journal of Symbolic Computation'
+ volume 42 issue 5 (May 2007, pages 511-532) [doi:10.1016/j.jsc.2006.08.005]
+ uses this example as illustration (example 2.18 (b) p 520). At the time of
+ patching, it is not clear neither to the upstream maintainer nor to the
+ package maintainer whether or not the two answers are equivalent. Further
+ investigations are on their ways.
+ .
+ Meanwhile, to not introduce a faulty correction, the example is replaced by
+ its sibling (example 2.18 (a) p 520) whose the expected and observed final
+ answers are the same:
+ .
+   gap> J:=IdealAffineToricVariety([[0,1],[2,-1]]);
+   <two-sided ideal in Rationals[x_1,x_2,x_3], (1 generators)>
+   gap> GeneratorsOfIdeal(J);
+   [ -x_2^2+x_1 ]
+ .
+ Note that this test failure might hide a serious bug.
 Origin: vendor, Debian
-Forwarded: by-email
+Forwarded: https://github.com/gap-packages/toric/pull/3
 Author: Jerome Benoit <calculus at rezozer.net>
-Last-Update: 2016-12-14
+Last-Update: 2016-12-28
 
 --- a/doc/toric.xml
 +++ b/doc/toric.xml
@@ -13,13 +44,14 @@ Last-Update: 2016-12-14
  </ManSection>			  
  
  <Example>
-+<![CDATA[
- gap> J:=IdealAffineToricVariety([[1,0],[3,4]]);
+-gap> J:=IdealAffineToricVariety([[1,0],[3,4]]);
 -[ two-sided ideal in PolynomialRing(..., [ x_1, x_2 ]), (3 generators) ]
-+<two-sided ideal in Rationals[x_1,x_2,x_3,x_4,x_5], (3 generators)>
++<![CDATA[
++gap> J:=IdealAffineToricVariety([[0,1],[2,-1]]);
++<two-sided ideal in Rationals[x_1,x_2,x_3], (1 generators)>
  gap> GeneratorsOfIdeal(J);
 -[ -x_2^2+x_1, -x_2^3+x_1^2, -x_2^4+x_1^3 ]
-+[ -x_4^4+x_1, -x_4^3+x_2, -x_4^2+1 ]
++[ -x_2^2+x_1 ]
 +]]>
  </Example>
  
diff --git a/debian/patches/upstream-correct-documentation-examples-typo.patch b/debian/patches/upstream-correct-documentation-examples-typo.patch
index 8bba8e5..c3102b7 100644
--- a/debian/patches/upstream-correct-documentation-examples-typo.patch
+++ b/debian/patches/upstream-correct-documentation-examples-typo.patch
@@ -3,9 +3,9 @@ Description: upstream: correct examples in documentation: typo
  testing them (section 5.4 in GAPDoc Reference Manual); meant to
  be submitted to the upstream maintainer.
 Origin: vendor, Debian
-Forwarded: by-email
+Forwarded: https://github.com/gap-packages/toric/pull/2
 Author: Jerome Benoit <calculus at rezozer.net>
-Last-Update: 2016-12-14
+Last-Update: 2016-12-28
 
 --- a/doc/toric.xml
 +++ b/doc/toric.xml

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/gap-toric.git

