[hdf-compass] 37/295: cleaning up: removing dead code and print statements

Ghislain Vaillant ghisvail-guest at moszumanska.debian.org
Sun May 8 10:35:23 UTC 2016


This is an automated email from the git hooks/post-receive script.

ghisvail-guest pushed a commit to branch debian/master
in repository hdf-compass.

commit c38762e78ebcce4886fe8a659135693e8228aa59
Author: Matt Comerford <matthew.comerford at colorado.edu>
Date:   Wed Aug 6 11:25:44 2014 -0600

    cleaning up: removing dead code and print statements
---
 opendap_model/__init__.py | 124 +++-------------------------------------------
 1 file changed, 7 insertions(+), 117 deletions(-)

diff --git a/opendap_model/__init__.py b/opendap_model/__init__.py
index 90f9883..23531ac 100644
--- a/opendap_model/__init__.py
+++ b/opendap_model/__init__.py
@@ -1,59 +1,33 @@
 """
 HDF Compass plugin for accessing an OpENDAP server. 
 """
+
 import numpy as np
+import posixpath as pp
 from pydap.client import open_url
 from pydap.model import *
-import posixpath as pp
+from pydap.proxy import ArrayProxy
 
 import compass_model
 
 class Server(compass_model.Store):
 
     """
-        Represents the remote OpENDAP derver to be accessed
+        #Represents the remote OpENDAP derver to be accessed
     """
-    # For practice I will implement using the OpENDAP Test Server, found at:
-    # http://test.opendap.org/dap/data/nc/coads_climatology.nc
-
-    # Methods related to the plugin system
-    '''
-    def __getitem__(self, key):
-        # Open an object in the store, using the last registered class which reports it can open the key.
-        print 1
-        #return open_url(self._url)
-        #return self._dset
-        pass
-    '''
-    '''
-    def gethandlers(self, key=None):
-        # Retrieve all registered Node subclasses, optionally filtering by those which report they can handle "key"
-        print 2
-        pass
-    '''
 
     def __contains__(self, key):
-        # True if "key" exists in the store. False otherwise.
-        print 3
-        #return key in self._dset.keys()
         if key == '/':
             return True
         return False
 
-    # Other methods & properties
     @staticmethod
     def canhandle(url):
-        print 'canhandle'
         if not url.startswith('http://'):
             return False
-        #if not url.endswith('.nc'):
-        #    return False
         return True
-        # Return True if this class can make sense of "url". False otherwise.
 
     def __init__(self, url):
-        #Create a new store instance from the data at "url". False otherwise.
-        print 4
         if not self.canhandle(url):
             raise ValueError(url)
         self._url = url
@@ -61,37 +35,26 @@ class Server(compass_model.Store):
         self._dataset = open_url(self._url)
 
     def close(self):
-        # Discontinue access to the data store
         self._valid = False
         print 5
 
     def getparent(self, key):
-        # Return the object which contains "key", or None if no object exists
-        print 6
         return None
 
     @property
     def url(self):
-        # The "URL" used to open the store
-        print 7
         return self._url
 
     @property
     def displayname(self):
-        # A short name used for the store
-        print 8
         return self._dataset.name
 
     @property
     def root(self):
-        # A node instance representing the starting point in the file
-        # For hierarchiacal formats, this would be the root container.
-        print 9
         return self['/']
 
     @property
     def valid(self):
-        print 10
         return self._valid
 
 
@@ -103,39 +66,22 @@ class Structure(compass_model.Container):
 
     classkind = "Structure"
 
-    # Unique to the Container class
-    
     def __len__(self):
-        # Get the number of ojects directly attached to the Container
-        print 11
         return len(self._dset.data)
 
     def __getitem__(self, index):
-        # Retrieve the node at index.
-        # Returns a NODE INSTANCE, not a key
-        print "index is", index
-        print 12
-        #self._dset.get(self._dset.keys()[index]).attributes['displayname'] = self._dset.keys()[index]
         return self._dset.get(self._dset.keys()[index])
 
     def __iter__(self):
-        print 13
         pass
 
-    # General Node class implementations
-
     @staticmethod
     def canhandle(store, key):
-        # Determine whether this class can usefully represent the object.
-        # Keys are not technically required to be strings
-        print 14
         if type(store._dataset) == DatasetType or type(store._dataset) == StructureType:
             return True
         return False
 
     def __init__(self, store, key):
-        # Create a new instance representing the object pointed to by "key" in "store"
-        print 15
         self._store = store
         self._key = key 
         self._url = store.url
@@ -143,91 +89,47 @@ class Structure(compass_model.Container):
 
     @property
     def key(self):
-        # Unique key which identifies this object in the store
-        # Keys may be any hashable object, although strings are the most common
-        print 16
-        #print "self._key is ", self._key
         return self._key
 
     @property
     def store(self):
-        # The data store to which the object belongs
-        print 17
         return self._store
 
     @property
     def displayname(self):
-        # A short name for display purposes 
-        print 18
         return self._dset.name
 
     @property
     def description(self):
-        # Descriptive string
-        print 19
         return "Testing Structure Implementation"
 
 
 class Base(compass_model.Array):
 
     """
-    Represents Array/BaseType Object in OpENDAP/Pydap
+    #Represents Array/BaseType Object in OpENDAP/Pydap
     """
 
     classkind = "Base"
 
-    # Imports only used within this class
-    from pydap.proxy import ArrayProxy
-
-    # Implementations unique to Array class
-
     @property
     def shape(self):
-        # Shape of the array, as a Python tuple
-        print 20
         return self._dset.shape
 
     @property
     def dtype(self):
-        # NumPy data type object representing the type of the array
-        print 21
         return self._dset.dtype
 
-    '''
-    @property
-    def type(self):
-        print "type"
-        return type(self)
-    
-    @property
-    def classkind(self):
-        print "classkind"
-        return "BASETYPE"
-    '''
-
     def __getitem__(self, indices):
-        # Retrieve data from the array, using the standard array-slicing syntax.
-        # "indices" are slicing arguments
-        print 22
         return self._dset[indices]
 
-    # General Node class implementations
-
     @staticmethod
     def canhandle(store, key):
-        # Determine whether this class can usefully represent the object
-        # Keys are not technically required to be strings.
-
-        # If the type of the key stored in store is not 'pydap.model.BaseType' then false
-        #return key in store and type(key)
-        print 23
         if type(store._dataset) == BaseType:
             return True
         return False
 
     def __init__(self, store, key):
-        # Create a new instance representing the object pointed to by "key" in "store"
-        print 24
         self._store = store
         self._key = key
         self._id = self.id
@@ -237,36 +139,24 @@ class Base(compass_model.Array):
 
     @property
     def key(self):
-        # Unique key which identifies this object in the store.
-        # Keys may be any hashable object
-        print 25
         return self._key
 
     @property
     def store(self):
-        # The data store to which the object belongs
-        print 26
         return self._store
 
     @property
     def displayname(self):
-        #  A short name for display purposes
-        print 27
-        return "test"
-        #return self._dset.name
+        return self._dset.name
 
     @property
     def description(self):
-        # A descriptive string
-        print 28
-        return "A Descriptive String"
+        return self._dset.id
 
     @property
     def id(self):
-        print 29
         return self._id
 
-
 # Register Handlers
 Server.push(Structure)
 Server.push(Base)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/hdf-compass.git



More information about the debian-science-commits mailing list