[clapack] 01/02: Exclude complete test for format handling which breaks format security and should be fullfilled on any linux machine anyway; Skip iunit tests requring larger than usual stack size

Andreas Tille tille at debian.org
Sat May 21 11:49:40 UTC 2016


This is an automated email from the git hooks/post-receive script.

tille pushed a commit to branch master
in repository clapack.

commit 3c575ba0382bf26d1172e6ac74e8a44f2718c99a
Author: Andreas Tille <tille at debian.org>
Date:   Sat May 21 09:56:46 2016 +0200

    Exclude complete test for format handling which breaks format security and should be fullfilled on any linux machine anyway; Skip iunit tests requring larger than usual stack size
---
 debian/patches/format-security.patch               | 24 +++++--
 debian/patches/series                              |  3 +-
 .../skip_tests_triggering_stack_overflow.patch     | 82 ++++++++++++++++++++++
 3 files changed, 102 insertions(+), 7 deletions(-)

diff --git a/debian/patches/format-security.patch b/debian/patches/format-security.patch
index 9910cfc..18af08f 100644
--- a/debian/patches/format-security.patch
+++ b/debian/patches/format-security.patch
@@ -1,11 +1,23 @@
+Author: Andreas Tille
+Last-Update: Sat, 21 May 2016 09:41:25 +0200
+Description: Test breaks format security and should be fullfilled on Linux anyway.
+ (See discussion on debian-mentors list in May 2016)
+
 --- a/F2CLIBS/libf2c/arithchk.c
 +++ b/F2CLIBS/libf2c/arithchk.c
-@@ -110,7 +110,7 @@ icheck(void)
+@@ -122,6 +122,7 @@ ccheck(void)
+ 	long Cray1;
+ 
+ 	/* Cray1 = 4617762693716115456 -- without overflow on non-Crays */
++/* Skip useless test
+ 	Cray1 = printf(emptyfmt) < 0 ? 0 : 4617762;
+ 	if (printf(emptyfmt, Cray1) >= 0)
+ 		Cray1 = 1000000*Cray1 + 693716;
+@@ -130,6 +131,7 @@ ccheck(void)
+ 	u.d = 1e13;
+ 	if (u.L == Cray1)
+ 		return &CRAY;
++*/
  	return 0;
  	}
  
--char *emptyfmt = "";	/* avoid possible warning message with printf("") */
-+char *emptyfmt = "%s";	/* avoid possible warning message with printf("") */
- 
-  static Akind *
- ccheck(void)
diff --git a/debian/patches/series b/debian/patches/series
index 3e8783a..4639c2c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
-# format-security.patch
+format-security.patch
+skip_tests_triggering_stack_overflow.patch
diff --git a/debian/patches/skip_tests_triggering_stack_overflow.patch b/debian/patches/skip_tests_triggering_stack_overflow.patch
new file mode 100644
index 0000000..7f2def3
--- /dev/null
+++ b/debian/patches/skip_tests_triggering_stack_overflow.patch
@@ -0,0 +1,82 @@
+Author: Andreas Tille
+Last-Update: Sat, 21 May 2016 09:41:25 +0200
+Description: Suppress tests requiring to large stack
+ On 05/16/2016 01:50 PM, Danny Edel wrote:
+   after compiling, the test suite
+   crashed on the xeigtstz_* with Segmentation Fault errors.
+ .
+   I debugged this a little bit and the reason was these tests use a lot of
+   local (i.e. stack) variables -- so many in fact that they trigger a
+   stack overflow on entry.
+ .
+   Disabling stack size limit (mine was 8192 KB) with
+      ulimit -s unlimited
+   before calling dpkg-buildpackage fixed things for me.
+ .
+ Instead of fiddling around wuth ulimit these tests are disabled
+ for the moment
+
+--- a/TESTING/CMakeLists.txt
++++ b/TESTING/CMakeLists.txt
+@@ -236,61 +236,5 @@ add_lapack_test(dgsv.out gsv.in xeigtstd
+ 
+ add_lapack_test(dlse.out lse.in xeigtstd)
+ 
+-#
+-# ======== COMPLEX16 EIG TESTS ===========================
+-
+-add_lapack_test(znep.out nep.in xeigtstz)
+-
+-
+-add_lapack_test(zsep.out sep.in xeigtstz)
+-
+-
+-add_lapack_test(zsvd.out svd.in xeigtstz)
+-
+-
+-add_lapack_test(zec.out zec.in xeigtstz)
+-
+-
+-add_lapack_test(zed.out zed.in xeigtstz)
+-
+-
+-add_lapack_test(zgg.out zgg.in xeigtstz)
+-
+-
+-add_lapack_test(zgd.out zgd.in xeigtstz)
+-
+-
+-add_lapack_test(zsb.out zsb.in xeigtstz)
+-
+-
+-add_lapack_test(zsg.out zsg.in xeigtstz)
+-
+-
+-add_lapack_test(zbal.out zbal.in xeigtstz)
+-
+-
+-add_lapack_test(zbak.out zbak.in xeigtstz)
+-
+-
+-add_lapack_test(zgbal.out zgbal.in xeigtstz)
+-
+-
+-add_lapack_test(zgbak.out zgbak.in xeigtstz)
+-
+-
+-add_lapack_test(zbb.out zbb.in xeigtstz)
+-
+-
+-add_lapack_test(zglm.out glm.in xeigtstz)
+-
+-
+-add_lapack_test(zgqr.out gqr.in xeigtstz)
+-
+-
+-add_lapack_test(zgsv.out gsv.in xeigtstz)
+-
+-
+-add_lapack_test(zlse.out lse.in xeigtstz)
+-
+ # ==============================================================================
+ 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/clapack.git



More information about the debian-science-commits mailing list