r118 - in /debtorrent/trunk: DebTorrent/BT1/AptListener.py TODO

[camrdale-guest at users.alioth.debian.org]

Author: camrdale-guest
Date: Tue Jun 19 22:45:36 2007
New Revision: 118

URL: http://svn.debian.org/wsvn/debtorrent/?sc=1&rev=118
Log:
Fix up some of the TODO stuff.

Modified:
    debtorrent/trunk/DebTorrent/BT1/AptListener.py
    debtorrent/trunk/TODO

Modified: debtorrent/trunk/DebTorrent/BT1/AptListener.py
URL: http://svn.debian.org/wsvn/debtorrent/debtorrent/trunk/DebTorrent/BT1/AptListener.py?rev=118&op=diff
==============================================================================
--- debtorrent/trunk/DebTorrent/BT1/AptListener.py (original)
+++ debtorrent/trunk/DebTorrent/BT1/AptListener.py Tue Jun 19 22:45:36 2007
@@ -481,7 +481,6 @@
 
             # First check the cache for the file
             r = self.Cache.cache_get(path, uptodate, headers.get('if-modified-since', ''))
-            # TODO: watch out for getting cached deb's that haven't yet downloaded (with saveas_style 2)
             
             # If the cache doesn't have it
             if r[0] not in (200, 304):
@@ -495,7 +494,6 @@
                     return None
             
             if path[-1] in ('Packages', 'Packages.gz', 'Packages.bz2'):
-                # TODO: check if the torrent is already running before this
                 if r[0] == 304:
                     # Oops, we do need the cached file after all to start the torrent
                     r2 = self.Cache.cache_get(path)

Modified: debtorrent/trunk/TODO
URL: http://svn.debian.org/wsvn/debtorrent/debtorrent/trunk/TODO?rev=118&op=diff
==============================================================================
--- debtorrent/trunk/TODO (original)
+++ debtorrent/trunk/TODO Tue Jun 19 22:45:36 2007
@@ -1,4 +1,34 @@
 Below are some things that still need to be done, in order of priority.
+
+
+Don't ignore Packages.diff
+
+Currently requests for Packages.diff return a 404 not found error, as the 
+AptListener doesn't yet know how to process these. This should be improved to 
+store a cached copy of the Packages file, and apply the diffs to it as they 
+download, then use the final file as the torrent file. Security checking of
+the hashes of the diffs or the final file may be necessary.
+
+
+Check if the torrent is already running before getting it from the cache
+
+When a Packages download results in a 304 not modified message because the
+file is in the cache and up to date with the server, the Packages file
+still needs to be uncompressed and turned into a torrent to determine if it
+is currently running or not. This is time consuming and unnecessary. A better
+solution is to store some information about which Packages files belong to 
+which running torrents, and then check that.
+
+
+Check for problems with the experimental saveas_style 2 
+
+Using the saveas_style = 2 option saves the files downloaded from the torrents
+in the same directory structure as the files downloaded by proxy. This is more
+efficient, since the files can be retrieved by the cacher without having to
+check the running torrents for them. However, it could also cause problems if
+the file has not yet completed downloading (will fail hash check). Some
+investigation needs to be done of the possiblity of this and how best to check
+for it.
 
 
 AptListener queue waiting for downloads should be implemented using callbacks