Bug#695795: use annotated git tags (even whenever no signing requested)

[Yaroslav Halchenko]

Package: devscripts
Version: 2.12.6
Severity: normal
File: /usr/bin/debcommit

At the moment debcommit -r provides commit message only when creating signed tags:

    if ($signtags) {
        if (defined $keyid) {
            if (! action($prog, "tag", "-u", $keyid, "-m",
                         "tagging version $tag", $tag)) {
                    die "debcommit: failed tagging with $tag\n";
            }
        }
        else {
            if (! action($prog, "tag", "-s", "-m",
                         "tagging version $tag", $tag)) {
                    die "debcommit: failed tagging with $tag\n";
            }
        }
    }
    elsif (! action($prog, "tag", $tag)) {
            die "debcommit: failed tagging with $tag\n";
        }
    }

but actually with git it should always provide -m  to create an annotated tag,
which are the "real" tags in GIT.  'git tag' without message/annotation creates
merely a pointer, without any meta-information (e.g. date/author,etc) and thus
such tags do not even considered by 'git describe' by default (explicit --tags
is needed).  such lightweight tags could be used by people to mark some
temporary or non-release specific locations in the development history,
so just demanding using --tags all the time is also suboptimal.

more of food for thought on why to use annotated tags:
http://stackoverflow.com/questions/4971746/why-should-i-care-about-lightweight-vs-annotated-tags

Cheers,

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental'), (100, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages devscripts depends on:
ii  dpkg-dev  1.16.9
ii  libc6     2.13-33
ii  perl      5.14.2-12
ii  python    2.7.3-3

Versions of packages devscripts recommends:
ii  at                        3.1.13-2
ii  curl                      7.26.0-1
ii  dctrl-tools               2.22.2
ii  debian-keyring            2012.06.01
ii  dput                      0.9.6.3
ii  dupload                   2.7.0
ii  equivs                    2.0.9
ii  fakeroot                  1.18.4-2
ii  gnupg                     1.4.12-4+b1
ii  libcrypt-ssleay-perl      0.58-1
ii  libdistro-info-perl       0.10
ii  libjson-perl              2.53-1
ii  libparse-debcontrol-perl  2.005-3
ii  libsoap-lite-perl         0.714-1
ii  liburi-perl               1.60-1
ii  libwww-perl               6.04-1
ii  lintian                   2.5.10.2
ii  man-db                    2.6.2-1
ii  patch                     2.6.1-3
ii  patchutils                0.3.2-1.1
ii  python-debian             0.1.21
pn  python-magic              <none>
ii  sensible-utils            0.0.7
ii  strace                    4.5.20-2.3
ii  unzip                     6.0-7
ii  wdiff                     1.1.2-1
ii  wget                      1.13.4-3
ii  xz-utils                  5.1.1alpha+20120614-1

Versions of packages devscripts suggests:
ii  bsd-mailx [mailx]            8.1.2-0.20111106cvs-1
ii  build-essential              11.5
pn  cvs-buildpackage             <none>
pn  devscripts-el                <none>
ii  gnuplot                      4.6.0-8
ii  libauthen-sasl-perl          2.1500-1
ii  libfile-desktopentry-perl    0.04-3
ii  libnet-smtp-ssl-perl         1.01-3
ii  libterm-size-perl            0.207-1
ii  libtimedate-perl             1.2000-1
ii  libyaml-syck-perl            1.20-1
ii  mutt                         1.5.21-6.2
ii  openssh-client [ssh-client]  1:6.0p1-3
ii  svn-buildpackage             0.8.5
ii  w3m                          0.5.3-8

-- no debconf information