Bug#695914: marked as pending

[James McCoy]

On Dec 20, 2012 9:34 AM, "Ansgar Burchardt" <ansgar at debian.org> wrote:
>
> On 12/20/2012 02:07 PM, James McCoy wrote:
> > On Thu, Dec 20, 2012 at 11:36:16AM +0100, Ansgar Burchardt wrote:
> >> Mixing the status output from gpg and the data is a bad idea. It's
> >> probably still possible to bypass the check with something like
> >
> > Good point.  I just pushed an update:
> >
> >
http://anonscm.debian.org/gitweb/?p=devscripts/devscripts.git;a=commit;h=3e4b99becfc2e978887f2a52124970318bafe943
>
> Thanks, that looks better.
>
> Just one more question: why do you use Temp::File->newdir() when you
> only want a single file? Wouldn't Temp::File->new() be easier as you
> would no longer need the open() call in the next line.

I tried that first. :-) File::Temp goes through pains to ensure that temp
files have FD_CLOEXEC set. I took the approach of avoiding that by creating
the file myself, but I guess I could have just unset the flag.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20121220/80e1b162/attachment.html>