Bug#583750: [licensecheck] Patch to provide structured output

[Eric Lavarde]

Hello,

On 17/07/12 11:20, Benjamin Drung wrote:
> tags 583750 - patch
> thanks
>
> Am Sonntag, den 15.07.2012, 20:38 +0200 schrieb Eric Lavarde:
>> my initial patch was never included, here an updated version, perhaps
>> it'll have more chance this time.
>
> Your patch seems to be incomplete. It adds a --machine flag, but it is
> not used anywhere. Can you please update the licensecheck man page?
Uups, absolutely sorry. I'm not too sure what actually happened, but 
here is the complete patch.
Don't you generate the man page out of the (already updated) perldoc in 
the script!? I (quickly) looked at your package and didn't find any 
other place...

>
> You can gain extra points by adding test cases to
> test/test_licensecheck.
Extra points would be good, but I didn't plan to look actually at your 
package, just at your script. I nevertheless tried to quickly look at 
it, but the test script is using shunit2, which I don't know, so I 
stopped there (sorry, I do my best to help with my limited time).

Hope it nevertheless helps,
Eric

-------------- next part --------------
A non-text attachment was scrubbed...
Name: licensecheck.patch.gz
Type: application/x-gzip
Size: 1048 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120719/d29a4b6e/attachment.bin>