licensecheck: improvements

[James McCoy]

On Wed, Oct 10, 2012 at 01:49:28PM +1100, Dmitry Smirnov wrote:
> On Wed, 10 Oct 2012 05:28:29 Benjamin Drung wrote:
> > PS: Sorry for being a perfectionist.
> 
> No excuse. We won't make any progress like this.
> This is not perfectionism but protectionism as you effectively (de-facto) 
> protect licensecheck from any changes.

I haven't had a chance yet to read through all the patches, but this
caught my eye.

From the brief glance that I have had at the patches, there are plenty
of unnecessary changes mixed in among the useful changes.

A new contributor should expect to adapt to a project's existing style
and guidelines, not the other way around.  If you want to change those,
then you can raise a discussion about it.  Just throwing patches over
the wall and expecting us to take them wholesale because you've already
done the work isn't going to fly.

As far as project membership, that's not necessary to contribute.  Patch
sets (as you've done here) or a git repository to pull from will work
too.

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20121009/a8ec8ecd/attachment.pgp>