Bug#691389: [checkbashisms] multiple bug fixes and new checks

[Benjamin Drung]

Am Mittwoch, den 24.10.2012, 21:15 -0500 schrieb Raphael Geissert:
> Attached is an mbox with a bunch of bug fixes and new checks, #687450 
> included.

Thanks. I have applied your patches 1 up to 14. I grabbed the working
test cases from your git repository and added them to devscripts. After
applying a patch, I added the newly passing test cases. Feel free to add
more test cases to devscripts or to improve/simplify the shunit2 tests.

Patch 15 refers to commit 5dc48224, but the commit hashes do not survive
git format-patch & git am. To which commit do you refer?

Please do not sign off your own patches. Your patches will be signed off
by the person that applies your patches.

You can send your patches directly to the mailing list if have more than
one instead of opening a new bug report.

Can you add a commit with your changelog entries?

> On IRC I mentioned a "regression" when checking autoconf, but the issue is 
> now visible thanks to some bug fixes. In one configure script the bug fix 
> actually revealed a bashism.

Have you created a test case for this regression?

> P.S. don't take too much of the function name regexes, beware :)

Your regexes cannot win the Perl uglifying contest. :)

-- 
Benjamin Drung
Debian & Ubuntu Developer