Bug#691389: [checkbashisms] multiple bug fixes and new checks

Benjamin Drung bdrung at debian.org
Fri Oct 26 20:27:43 UTC 2012


Am Freitag, den 26.10.2012, 12:13 -0400 schrieb James McCoy:
> On Fri, Oct 26, 2012 at 02:31:34PM +0200, Benjamin Drung wrote:
> > Am Donnerstag, den 25.10.2012, 17:33 -0500 schrieb Raphael Geissert:
> > > > Please do not sign off your own patches. Your patches will be signed off
> > > > by the person that applies your patches.
> > > 
> > > Perhaps we differ on what the sign off means, and that shouldn't cause any 
> > > issue for another person to sign off them as well.
> > 
> > I found two meaning of signing off patches:
> > 
> > 1) The signer certifies that he/she have created the patch in question
> > and take responsibility for the copyright status of the code in
> > question.
> > 
> > 2) The signer reviewed the patch and has done some sort of QA.
> > 
> > We use the second meaning.
> 
> We do, along with an optional application of the first.  I tend to do
> both, but not everyone does.  I see no reason to request people elide
> the first type.

I wasn't aware of the first meaning until Raphael's response. Then I did
a research and found both meanings.

-- 
Benjamin Drung
Debian & Ubuntu Developer



More information about the devscripts-devel mailing list