Bug#688088: [licensecheck] misses additional clauses

[chrysn]

Package: devscripts
Version: 2.12.3
Severity: normal
File: /usr/bin/licensecheck

when a zlib style license gets additional clauses (which, by the nature
of the zlib license, almost certainly restrict the software's usage), it
still gets detected as zlib/png.

the license in question:

 * @section License
 * <b>(C) Copyright 2012 Energy Micro AS, http://www.energymicro.com</b>
 *******************************************************************************
 *
 * Permission is granted to anyone to use this software for any purpose,
 * including commercial applications, and to alter it and redistribute it
 * freely, subject to the following restrictions:
 *
 * 1. The origin of this software must not be misrepresented; you must not
 *    claim that you wrote the original software.
 * 2. Altered source versions must be plainly marked as such, and must not be
 *    misrepresented as being the original software.
 * 3. This notice may not be removed or altered from any source distribution.
 * 4. The source and compiled code may only be used on Energy Micro "EFM32"
 *    microcontrollers and "EFR4" radios.

i'd like to suggest that licenses with numbered items fail to apply when
followed by a next item, or at least indicate that they have additional
clauses.

(for context: i've found that license in an upstream tarball most of
whose files only contained the three items, and used licensecheck to see
if there are files with different licenses)

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DSCVERIFY_KEYRINGS=~/.gnupg/debian.gpg
DEBSIGN_KEYID=398D1112D3A4BDE1

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.4-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages devscripts depends on:
ii  dpkg-dev  1.16.8
ii  libc6     2.13-35
ii  perl      5.14.2-13
ii  python    2.7.3-2

Versions of packages devscripts recommends:
ii  at                        3.1.13-2
ii  curl                      7.27.0-1
ii  dctrl-tools               2.22.2
ii  debian-keyring            2012.06.01
ii  dput                      0.9.6.3
ii  dupload                   2.7.0
ii  equivs                    2.0.9
ii  fakeroot                  1.18.4-2
ii  gnupg                     1.4.12-4+b1
ii  libcrypt-ssleay-perl      0.58-1
ii  libdistro-info-perl       0.10
ii  libjson-perl              2.53-1
ii  libparse-debcontrol-perl  2.005-3
ii  libsoap-lite-perl         0.714-1
ii  liburi-perl               1.60-1
ii  libwww-perl               6.04-1
ii  lintian                   2.5.10.1
ii  man-db                    2.6.2-1
ii  patch                     2.6.1-3
ii  patchutils                0.3.2-1.1
ii  python-debian             0.1.21+nmu2
ii  python-magic              5.11-2
ii  sensible-utils            0.0.7
ii  strace                    4.5.20-2.3
ii  unzip                     6.0-7
ii  wdiff                     1.1.2-1
ii  wget                      1.14-1
ii  xz-utils                  5.1.1alpha+20120614-1

Versions of packages devscripts suggests:
ii  bsd-mailx [mailx]            8.1.2-0.20111106cvs-1
ii  build-essential              11.5
pn  cvs-buildpackage             <none>
pn  devscripts-el                <none>
ii  gnuplot                      4.6.0-8
pn  libauthen-sasl-perl          <none>
ii  libfile-desktopentry-perl    0.04-3
pn  libnet-smtp-ssl-perl         <none>
pn  libterm-size-perl            <none>
ii  libtimedate-perl             1.2000-1
ii  libyaml-syck-perl            1.20-1
ii  mutt                         1.5.21-6.2
ii  openssh-client [ssh-client]  1:6.0p1-3
ii  svn-buildpackage             0.8.5
ii  w3m                          0.5.3-8

-- no debconf information

-- 
To use raw power is to make yourself infinitely vulnerable to greater powers.
  -- Bene Gesserit axiom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20120919/0425643a/attachment.pgp>