Bug#663357: uscan: Please support scanning git repositories for tags

[Maximiliano Curia]

¡Hola!

El Tuesday, April 23, 2013 a las 11:29 Niels Thykier escribió:
> Hi,

> (Disclaimer: not the maintainer).

> Interesting idea and I suspect it will be very useful.

Thanks, I appreciate the possitive feedback, even if the never gets accepted.

> > -    }
> > -    else {
> > +    } elsif ($site =~ m%^git://%) {
> > +	# TODO: check if there is a git command
> > +	#       sanitize $base
> > +	open(REFS, "git ls-remote $base |");

> Why do you use "2-arg open" here?  A "3-arg open" would avoid issues
> with quoting.  E.g.

>     open(REFS, '-|', 'git', 'ls-remote', $base)

> Also, the return value of open is not checked.  So if it fails (e.g. git
> is not installed) it will cause a lot of warnings from reading an
> "unopened handle".

Yeah, you are right. I added those changes to the attached patch, also removed 
the unneeded message for the recursive search, and added the missing parts to 
generate the tar.gz file.

-- 
"Whenever possible, steal code." -- Tom Duff
Saludos /\/\ /\ >< `/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: devscripts_uscan_git-support.1.patch
Type: text/x-patch
Size: 3654 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20130423/78c176ac/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20130423/78c176ac/attachment-0001.pgp>