[PATCH 0/4] licensecheck: eliminate false positives, and improve BSD-3 detection

[Philip Hands]

Benjamin Drung <bdrung at debian.org> writes:

> Am Montag, den 14.01.2013, 11:49 +0000 schrieb Philip Hands:
>> These patches are inspired by my attempt to give freeswitch a worthwhile
>> debian/copyright file.
>> 
>> freeswitch bundles a lot of libraries in its source, and some of them are
>> a bit of a mess, so if some of this patch makes you suspicious, it may
>> be that I'm trying to fix things here that should be fixed in the source
>> for freeswitch.  Please just ask about anything you're doubtful about and
>> I'll point you at the reason I added it -- I was initially trying to do
>> that in the separate patches, but the last one is all lumped together,
>> so not as informative as it might have been.
>
> Thanks for your four patches. Can you construct a small test-case for
> every patch?

Fair enough.

I've redone that lot as separated patches, and added a test for each.
Not knowing the convention, I did this with paired commits: adding a
test that demonstrates the bug, followed by the patch that fixes it.

I've just pushed that all to branch:  philh-licensecheck

It's not quite the same as the patches I mailed, because I seem not to
have found all of the bits that prompted my patches, so I'll leave the
rest until I bump into the proper test cases again.

Also, I noticed that the problem with files that have leading == or ::
in them can be fixed in a much better way than I'd tried already.

The old patch set should therefor be disregarded.

Feel free to grab that branch into the master branch and delete it, or
if you like I can do all that for you.

Cheers, Phil.
-- 
|)|  Philip Hands [+44 (0)20 8530 9560]    http://www.hands.com/
|-|  HANDS.COM Ltd.                    http://www.uk.debian.org/
|(|  10 Onslow Gardens, South Woodford, London  E18 1NE  ENGLAND
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20130220/a13e4e8c/attachment.pgp>