Bug#610712: [devscripts] Allow to check cryptographic signatures

[Daniel Kahn Gillmor]

On 06/05/2013 09:24 PM, James McCoy wrote:
>> I took a quick look at the patch and found to things: 1) Please update
>> README in addition to d/control and 2) please check the indentation.
> 
> A little clarification on this.  uscan uses (as most of the shell/Perl
> scripts in devscripts do) the following indent style:
> 
>  - Each indent level is 4 columns
>  - Use tabs when the indent is a multiple of 8
>  - Use spaces for the rest
> 
> There are some hunks in your patch that should be updated accordingly.

thanks, i've just pushed two commits: one that includes some emacs
localvars so that future emacs-using contributors should have "the
right" whitespace, and a patch with cleaned-up whitespace that also
updates the README, as recommended by Benjamin.

I did not add a test to uscan because i don't have a place that i want
to commit to storing an example package and signature, and i'm generally
distrustful of tests that run against external network services.

if anyone wants to make such a test i'd be happy to walk through the
signature creation part.

>>> As a DD, I'm a member of collab-maint --
>>> should i just go ahead and commit it to the devscripts repo?  It works
>>> for me, and i would like to start using it for debian packages that have
>>> an upstream that signs releases.
>>
>> I vote for "go ahead". Welcome in the devscripts devel team!
> 
> Agreed.

thanks for the vote of confidence!  I look forward to seeing this
feature in uscan.  Feel free to ping me if there are any problems.

	--dkg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1027 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20130606/67a81493/attachment.pgp>