Bug#685787: Praat has serious bug #713597

[Benjamin Drung]

On Mi, 2013-10-30 at 09:45 +0100, Rafael Laboissiere wrote:
> * Andreas Tille <tille at debian.org> [2013-10-29 10:33]:
> 
> > On Mon, Oct 28, 2013 at 07:06:37PM -0400, James McCoy wrote:
> >> Thanks Rafael for the feedback and Andreas for continued patience.
> >>
> >> On Mon, Oct 28, 2013 at 10:10:00PM +0100, Andreas Tille wrote:
> >>> On Mon, Oct 28, 2013 at 07:44:57PM +0100, Rafael Laboissiere wrote:
> >>>> It would be preferable that you had created a side branch in the Git
> >>>> repository for your changes, such that the merge would be trivial to
> >>>> do.
> >>
> >> This really wouldn't have made much of a difference.  It's trivial to 
> >> add Andrea's repo as a remote and then the functionality is the same as 
> >> if the branch were in devscripts' repo.  At the time that Andreas 
> >> started work on this, devscripts wasn't in collab-maint so it made sense 
> >> to just push his changes to a user repo on Alioth so people could access 
> >> and review the changes.
> 
> For the convenience of the developers of devscript, I am attaching below 
> a patch generated with git format-patch that contains an appropriate log 
> message.  I cherry-picked the commits made by Andreas Tille and Gregor 
> Herrmann into the Andreas' repo, which concern only the implementation of 
> the Files-Excluded feature.  I did also some improvements on my own. his 
> patch works for me on the praat package, but was not extensively tested. 
> At any rate, this "slim" patch introduces a single feature, namely the 
> possibility of excluding files from upstream tarballs according to 
> information in debain/copyright.
> 
> If I had push access to the devscripts repository, I could create a 
> side branch there with this patch.

The patch looks good on a quick look. I haven't applied or tested it. I
leave the integration to James, who offered to work on it.

I have just one recommendation/wish: It would be nice if test cases
could be added for the new feature. The test cases should work offline.

-- 
Benjamin Drung
Debian & Ubuntu Developer