Bug#685787: Praat has serious bug #713597
Rafael Laboissiere
rafael at laboissiere.net
Sat Nov 2 17:40:08 UTC 2013
* Benjamin Drung <bdrung at debian.org> [2013-11-02 13:08]:
> On Sa, 2013-11-02 at 12:03 +0100, Rafael Laboissiere wrote:
>> * Benjamin Drung <bdrung at debian.org> [2013-11-02 00:05]:
>>>
>>> I have just one recommendation/wish: It would be nice if test cases
>>> could be added for the new feature. The test cases should work offline.
>>
>> Would something along the lines of the very simple-minded shell script
>> attached below be appropriate? Of course, it will need adaptation for
>> the shunit2 framework used in devscripts.
>
> Yes, that's exactly what I hoped for. We already have test/test_uscan,
> which contains one online test. This could be converted to an offline
> test with your test framework.
>
>> What this script does is (1) create a minimal Debian package directory,
>> containing minimal files debian/{changelog,watch,copyright}, (2) create a
>> minimal repository, containing a tarball (built on the fly), and (3)
>> start an HTTP server that works offline, using the SimpleHTTPServer
>> module of Python.
>
> Maybe this short description could be added to the test case as comment
> (for documentation).
Ok, I did it and also changed test/Makefile accordingly. The patch is
attached below. Note that I also added an entry in debian/copyright, but
that may be wrong. There is no need to build-depend on libpython-stdlib
(for the SimpleHTTPServer module), because python3-all pulls it in. This
patch works here inside my pbuilder.
Cheers,
Rafael Laboissière
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-test-for-the-file-exclusion-feature-of-uscan.patch
Type: text/x-diff
Size: 3780 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20131102/2466337a/attachment.patch>
More information about the devscripts-devel
mailing list