Bug#685787: Praat has serious bug #713597

[Rafael Laboissiere]

* Benjamin Drung <bdrung at debian.org> [2013-11-03 00:24]:
>
> The modification on debian/copyright is okay. I have some comments:
>
> 1) I like to have one test file for each script which contains one or 
> more tests. So the test file for uscan should be called test_uscan and 
> contain a test function testFileExclusion using shunit.
>
> 2) The test in test_uscan should be converted to an offline test or 
> test_uscan should be renamed to test_uscan_online.
>
> 3) The test could do more validity checks. It could compare the list of 
> files in the tarball with the expected content.

Attached below is the patch implementing the above requests.  It renames 
test_uscan to test_uscan_online and includes the shunit2 test function 
testFileExclusion in test_uscan.  Two tests are included: first, it 
checks whether the "online download" of the tarball succeeded and, 
second, it checks whether the intended file was really excluded.

Here is the relevant part of the build log of the package:

    ./test_uscan
    testFileExclusion
    127.0.0.1 - - [03/Nov/2013 12:07:13] "GET / HTTP/1.1" 200 -
    127.0.0.1 - - [03/Nov/2013 12:07:13] "GET /foo-1.tar.gz HTTP/1.1" 200 -
    foo: Newer version (1) available on remote site:
      http://localhost:8000/foo-1.tar.gz
      (local version is 0)
    foo: Successfully downloaded updated package foo-1.tar.gz
        and removed files from it in foo_1+dfsg.orig.tar.gz

    Ran 1 test.

    OK


Rafael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-test-for-the-file-exclusion-feature-of-uscan.patch
Type: text/x-diff
Size: 7903 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20131103/5179f7b4/attachment.patch>