Bug#757481: devscripts: [mk-build-deps] broken --remove option

[Alessandro Ghedini]

Package: devscripts
Version: 2.14.6
Severity: important
Tags: patch

Hi,

commit ed03c060a90baca7d086f916c0f6fe8b05246049 included this change:
 
     if ($opt_remove) {
-	foreach my $file (@deb_files) {
+	foreach my $file (map { $_->{package} } @packages) {
 	    unlink $file;
 	}
     }

which broke the "--remove" option (and really doesn't make any sense). See the
attached patch that fixes this.

Cheers

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
Not present

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages devscripts depends on:
ii  dpkg-dev     1.17.10
ii  libc6        2.19-7
ii  perl         5.18.2-7
ii  python3      3.4.1-1
pn  python3:any  <none>

Versions of packages devscripts recommends:
pn  at                          <none>
ii  curl                        7.37.1-1
ii  dctrl-tools                 2.23
ii  debian-keyring              2014.04.25
ii  dput                        0.9.6.4
ii  equivs                      2.0.9
ii  fakeroot                    1.20.1-1
ii  file                        1:5.19-1
ii  gnupg                       1.4.18-2
pn  libdistro-info-perl         <none>
ii  libencode-locale-perl       1.03-1
ii  libjson-perl                2.61-1
ii  liblwp-protocol-https-perl  6.06-2
ii  libparse-debcontrol-perl    2.005-4
pn  libsoap-lite-perl           <none>
ii  liburi-perl                 1.64-1
ii  libwww-perl                 6.08-1
pn  lintian                     <none>
ii  man-db                      2.6.7.1-1
ii  patch                       2.7.1-5
ii  patchutils                  0.3.3-1
pn  python3-debian              <none>
pn  python3-magic               <none>
ii  sensible-utils              0.0.9
pn  strace                      <none>
pn  unzip                       <none>
ii  wdiff                       1.2.2-1
ii  wget                        1.15-1+b1
ii  xz-utils                    5.1.1alpha+20120614-2

Versions of packages devscripts suggests:
pn  bsd-mailx | mailx            <none>
ii  build-essential              11.6
pn  cvs-buildpackage             <none>
pn  devscripts-el                <none>
pn  gnuplot                      <none>
ii  gpgv                         1.4.18-2
pn  libauthen-sasl-perl          <none>
pn  libfile-desktopentry-perl    <none>
pn  libnet-smtp-ssl-perl         <none>
pn  libterm-size-perl            <none>
ii  libtimedate-perl             2.3000-2
pn  libyaml-syck-perl            <none>
ii  mutt                         1.5.23-1
ii  openssh-client [ssh-client]  1:6.6p1-7
pn  svn-buildpackage             <none>
pn  w3m                          <none>

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mk-build-deps-pass-the-file-name-not-the-package-nam.patch
Type: text/x-diff
Size: 716 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20140808/1673f30f/attachment.patch>