[devscripts] 01/03: uscan: Use HEAD instead of GET for signature checks

[James McCoy]

This is an automated email from the git hooks/post-receive script.

jamessan pushed a commit to branch master
in repository devscripts.

commit 79b2b1995e49666eacfcba9e98e4f9ee5559e4f0
Author: James McCoy <jamessan at debian.org>
Date:   Tue Jun 10 20:51:50 2014 -0400

    uscan: Use HEAD instead of GET for signature checks
    
    Only the existence of a valid URL is necessary to recommend the user
    investigate further for enabling gpg signature verification.
    Performing a GET can be quite expensive with certain server
    configurations.
    
    Closes: #750929
    Signed-off-by: James McCoy <jamessan at debian.org>
---
 debian/changelog | 2 ++
 scripts/uscan.pl | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index bb2b052..a7325cb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,8 @@ devscripts (2.14.5) UNRELEASED; urgency=medium
       about an unitialized variable.
     + utf-8 decode the maintainer name when reading it from the changelog.
       (Closes: #750855)
+  * uscan: Use HEAD instead of GET to check for possible GPG signature URLs.
+    (Closes: #750929)
 
  -- James McCoy <jamessan at debian.org>  Sat, 07 Jun 2014 15:31:54 -0400
 
diff --git a/scripts/uscan.pl b/scripts/uscan.pl
index 820fd3a..334040f 100755
--- a/scripts/uscan.pl
+++ b/scripts/uscan.pl
@@ -1452,7 +1452,7 @@ EOF
     } else {
 	print "-- Checking for common possible upstream OpenPGP signatures\n" if $verbose;
 	foreach my $suffix (qw(asc gpg pgp sig)) {
-	    my $sigrequest = HTTP::Request->new('GET' => "$upstream_url.$suffix");
+	    my $sigrequest = HTTP::Request->new('HEAD' => "$upstream_url.$suffix");
 	    my $sigresponse = $user_agent->request($sigrequest);
 	    if ($sigresponse->is_success()) {
 		uscan_warn "$pkg: Possible OpenPGP signature found at:\n   $upstream_url.$suffix.\n  Please consider adding opts=pgpsigurlmangle=s/\$/.$suffix/\n  to debian/watch.  see uscan(1) for more details.\n";

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/collab-maint/devscripts.git