Problem with *.zip archives

[Andreas Tille]

Hi Joachim,

On Fri, Mar 21, 2014 at 11:23:36AM +0100, Joachim Breitner wrote:
> > Did you also pushed this change?
> 
> sorry, didn’t... done.

Thanks.
 
> > When I proposed my first implementation the Files-Excluded was relative
> > to the unpackaging dir and html/img/project-support.jpg.  Yesterday I
> > learned (with some non-zip archive) that the implementation has changed
> > to the root of the tar archive and thus now the correct way to specify
> > the exclusion would be:
> > 
> >    Files-Excluded: */html/img/project-support.jpg
> > 
> > I simply assumed that the devscripts developers have good reasons for
> > this change and I do not mind much (except that I need to remember to
> > change some d/copyright files accordingly).
> 
> No, that was just me, based on what the testcases did (I like
> implementing along testcases) and later realized that it is not what
> others do. 

In this case I personally would prefer fixing the test cases.  When I
stumbled upon the change I was thinking why somebody has drawn this
"decision" and cam e up with the idea that it might be that your
implementation is more safe in the case of "dirty" tar achives coming
with more than one unpackaging directory.  So if you consider this a
fair reason we should perhaps fix the specification to allow this (since
currently not so many use cases of Files-Excluded are out there).
 
> > In any case if this change was intentionally we should probably fix the
> > specification at
> > 
> >    https://wiki.debian.org/UscanEnhancements
> > 
> > as well.
> 
> Ok, if that is the specification, I can adjust the implementation to
> match the specification, which also dictates that * should match / and .
> as well.

+1

> > > I’m having some trouble getting the Text::Glob to do what I want,
> > > especially with the Excluding-file-from-zip-without---repack that I was
> > > asked to put back in (do we really need that? Who uses uscan to download
> > > zip files without repacking them to tar),
> > 
> > I guess there is no point in keeping zip files at all and changing them
> > to tar ... and by default to tar.xz if you ask me.
> 
> So do we need to support zip-to-zip File-Exclusion?

If you ask me - no.

Kind regards

     Andreas.

-- 
http://fam-tille.de