mk-origtargz (Was: Problem with *.zip archives)

[Andreas Tille]

Hi Joachim,

On Sun, May 04, 2014 at 11:55:55PM +0200, Joachim Breitner wrote:
> Hi,
> > 
> > 
> > $ mk-origtargz ../camitk_3.3.1.orig.tar.gz 
> > Unknown or no compression used in ../camitk_3.3.1.orig.tar.gz. at /usr/bin/mk-origtargz line 335.
> > 
> > Any hint?
> 
> I get:
>         /tmp/camitk-3.2.2 $ mk-origtargz ../camitk_3.2.2.orig.tar.gz
>         Leaving ../camitk_3.2.2.orig.tar.gz where it is.
> 
> (which makes sense: tar tzf ../camitk_3.2.2.orig.tar.gz|grep swf lists
> no files).

Well, version 3.2.2 really has no swf files - I was talking about the
new upstream version 3.3.1.
 
> If I add "*/dicom" to Files-Excluded, I get
>         /tmp/camitk-3.2.2 $ mk-origtargz ../camitk_3.2.2.orig.tar.gz
>         Leaving ../camitk_3.2.2.orig.tar.gz where it is, deleting 168
>         files from it.
> and the file is smaller, so it looks like it is working as intended.

If I try this "experiment" O also get

$ mk-origtargz ../camitk_3.3.1.orig.tar.gz
Unknown or no compression used in ../camitk_3.3.1.orig.tar.gz. at /home/andreas/bin/mk-origtargz line 325.

> Note that "Files-Excluded: dicom" does _not_ work since James’s patch
> d7f603e2e15257be0c539a1f62b097f3a2109892, which makes sure the same
> semantics as for "Files" stanza is used, and there it is specified:
>         Patterns match pathnames that start at the root of the source
>         tree. Thus, "Makefile.in" matches only the file at the root of
>         the tree, but "*/Makefile.in" matches at any depth.
> 
> Not sure what broke for you. Do you have "file" installed?

Looking into the code I think I found the problem:

$ file ../camitk_3.3.1.orig.tar.gz
../camitk_3.3.1.orig.tar.gz: symbolic link to `camitk-3.3.1-indigo-Source.tar.gz'

When mk-origtargz is called by uscan the file in question is no symlink.
However, if used separately it might perfectly happen that the file is a
symlink and thus the code should probably follow this link to obtain the
compression method.  I can confirm that mk-origtargz works as described
if I specify the target of the symlink.

However, if I use

mk-origtargz --compression xz ../camitk-3.3.1-indigo-Source.tar.gz

I only get a gzipped result (../ camitk_3.3.1+dfsg.orig.tar.gz) instead
of an xz compressed repackaged tarball.  It seems, specifying the
compression method does not work as expected.

Kind regards

        Andreas.

-- 
http://fam-tille.de