Z compression not yet supported (Was: mk-origtargz)

[Joachim Breitner]

Hi,

Am Mittwoch, den 14.05.2014, 08:54 +0200 schrieb Andreas Tille:
> On Tue, May 13, 2014 at 11:19:45PM -0400, James McCoy wrote:
> > > 
> > > The attached patch (not yet fully) supports Z compression.  It would
> > > need also enabling this compression in
> > > 
> > >    libdpkg-perl: /usr/share/perl5/Dpkg/Compression.pm
> > > 
> > > While it seems a quite rare case I'd consider it useful to support this
> > > compression method as well.
> > 
> > For completeness or because you actually have upstreams that use it?
> 
> I definitely have upstreams that are using it - just stumbled upon one
> (why do you think I came up with this yesterday ;-)) and I'll bet we
> have at least 100 packages in Debian fitting this criterion (without
> having done any research whether my estimation is true).
> 
> > If it's the latter, then I'm fine with adding it.  I doubt libdpkg-perl
> > will accept a patch for it though since that's not a valid compressor
> > for Debian packages.

we could still ask. If not, we should simply copy the Dpkg::Compression
to Devscripts::Compression; the module is not very large and we already
add a new method in Devscripts::Compression.

> I have no idea about the role of Dpkg/Compression.pm - but .Z is
> definitely a compression which is used in the UNIX world.  Do you think
> it makes more sense to use something like
> 
>    if ( $comp =~ /Z/ ) {
>       # handle Z compression manually
>    } else {
>       # current code
>    }
> 
> to work around the fact that Debian packages are not using this?

I’d rather not have such work-arounds cluttered through the code.
Copying the code from Dpkg::Compression would be cleaner.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20140514/6001508c/attachment.sig>